Skip to content

Commit f52a696

Browse files
refine code
1 parent c544e03 commit f52a696

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

fluss-server/src/main/java/org/apache/fluss/server/kv/KvManager.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,8 @@ public void dropKv(TableBucket tableBucket) {
313313
TablePath tablePath = dropKvTablet.getTablePath();
314314
try {
315315
// Unregister RocksDB metrics from TableMetricGroup
316+
serverMetricGroup.unregisterRocksDBMetrics(tablePath, tableBucket);
317+
// Remove bucket metric group and clean up table metric group if needed
316318
serverMetricGroup.removeTableBucketMetricGroup(tablePath, tableBucket);
317319

318320
dropKvTablet.drop();

fluss-server/src/main/java/org/apache/fluss/server/metrics/group/TabletServerMetricGroup.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,19 @@ public void registerRocksDBMetrics(
278278
tableMetricGroup.registerRocksDBMetrics(tableBucket, rocksDBMetrics);
279279
}
280280

281+
/**
282+
* Unregister RocksDB metrics for a specific table bucket.
283+
*
284+
* @param tablePath the table path
285+
* @param tableBucket the table bucket
286+
*/
287+
public void unregisterRocksDBMetrics(TablePath tablePath, TableBucket tableBucket) {
288+
TableMetricGroup tableMetricGroup = metricGroupByTable.get(tablePath);
289+
if (tableMetricGroup != null) {
290+
tableMetricGroup.unregisterRocksDBMetrics(tableBucket);
291+
}
292+
}
293+
281294
public void removeTableBucketMetricGroup(TablePath tablePath, TableBucket bucket) {
282295
// get the metric group of the table
283296
TableMetricGroup tableMetricGroup = metricGroupByTable.get(tablePath);

0 commit comments

Comments
 (0)