feat(java): implement FinalFieldReplaceResolveSerializer for final fields with writeReplace/readResolve methods

[mchernyakov]

Why?

Based on the discussion #2786.
We can optimize the payload in cases where we have final fields in some Object.

re-created, closed PR #2904

What does this PR do?

Introduce FinalFieldReplaceResolver which does not write the classname into the payload.

Related issues

Does this PR introduce any user-facing change?

• Does this PR introduce any public API change?
• Does this PR introduce any binary protocol compatibility change?

Benchmark

[mchernyakov]

@chaokunyang re-created my PR, addressed your comments in slack, please check

[chaokunyang]

This is only used in codegen, how baout using Invoke expression to create serializer directly?

[chaokunyang]

If so, most of changes in this file can be removed

[mchernyakov]

@chaokunyang which one is more preferable

// BaseObjectCodecBuilder
....
  private static final TypeRef<?> FINAL_FIELD_SERIALIZER_TYPE =
      TypeRef.of(FinalFieldReplaceResolveSerializer.class);
...
// in private Expression getOrCreateSerializer(Class<?> cls, boolean isField)
        newSerializerExpr =
            new Expression.NewInstance(FINAL_FIELD_SERIALIZER_TYPE, foryRef, fieldTypeExpr);

or

// BaseObjectCodecBuilder
...
  private static final TypeRef<?> FINAL_FIELD_SERIALIZER_TYPE =
      TypeRef.of(FinalFieldReplaceResolveSerializer.class);
...
// in private Expression getOrCreateSerializer(Class<?> cls, boolean isField)
        newSerializerExpr =
            new Expression.StaticInvoke(
                FinalFieldReplaceResolveSerializer.class,
                "createSerializer",
                FINAL_FIELD_SERIALIZER_TYPE,
                foryRef,
                fieldTypeExpr);
...
// FinalFieldReplaceResolveSerializer
...
  @CodegenInvoke
  public static FinalFieldReplaceResolveSerializer createSerializer(Fory fory, Class type) {
    return new FinalFieldReplaceResolveSerializer(fory, type);
  }
...

?

[chaokunyang]

I prefer first one

[mchernyakov]

done cf8b80d

[chaokunyang]

super class will invoke :

  public ReplaceResolveSerializer(Fory fory, Class type) {
    super(fory, type);
    refResolver = fory.getRefResolver();
    classResolver = fory.getClassResolver();
    // `setSerializer` before `newJDKMethodInfoCache` since it query classinfo from `classResolver`,
    // which create serializer in turn.
    // ReplaceResolveSerializer is used as data serializer for ImmutableList/Map,
    // which serializer is already set.
    classResolver.setSerializerIfAbsent(type, this);

classResolver.setSerializerIfAbsent(type, this); may set wrong serializer, could we add another protected contrcutore in parent class to pass setSerializer param and pass false here?

[mchernyakov]

8c7127a

[chaokunyang]

Hi @mchernyakov , sorry for review late. I've reviewed this PR, most of parts are fine, I left some minor comments. We can merge it after those are resolved.

And since it changes binary compatibility, we will include this PR in 0.14.0 instead 0.13.2

[chaokunyang]

waht does this TODO means?

[chaokunyang]

Could we also document that this serializer only works for consist mode, and add checks in FinalFieldReplaceResolveSerializer constructor.

[mchernyakov]

added in 446cc65 and removed the TODO

[chaokunyang]

LGTM