GEODE-10225: Gfsh start commands add exports on JDK 11+ (#7572)

PROBLEM

When run on JDK 17, numerous acceptance tests fail because a launched
locator or server requires access to the following packages:
- java.base/sun.nio.ch
- java.management/com.sun.jmx.remote.security

SOLUTION

- Add a `MemberJvmOptions` class that reports the JDK-dependent options
  required to launch a locator or server on the current process's JDK.
- Change `StartLocatorCommand` and `StartServerCommand` to add those
  options to the command line when launching locators and servers.

FUTURE

Future PRs will likely put these opens/exports in an argument file, then
configure these commands to use the argument file. We are deferring that
until we identify additional needs for the argument file, so we can
choose an appropriate location for the argument file.

Co-authored-by: Dale Emery <demery@vmware.com>
Co-authored-by: Kirk Lund <klund@apache.org>

Co-authored-by: Kirk Lund <klund@apache.org>

Author: demery-pivotal

geode-assembly/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandIntegrationTest.java

@@ -26,6 +26,8 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.util.Arrays;
+import java.util.List;
 import java.util.Properties;
 
 import org.junit.Before;
@@ -40,6 +42,8 @@
 
 public class StartLocatorCommandIntegrationTest {
   private static final String FAKE_HOSTNAME = "someFakeHostname";
+  private static final String LOCATOR_LAUNCHER_CLASS_NAME =
+      "org.apache.geode.distributed.LocatorLauncher";
 
   @Rule
   public GfshParserRule commandRule = new GfshParserRule();
@@ -91,11 +95,14 @@ public void startLocatorRespectsJmxManagerHostnameForClients() throws Exception
   public void startWithBindAddress() throws Exception {
     commandRule.executeAndAssertThat(spy, "start locator --bind-address=127.0.0.1");
 
-    ArgumentCaptor<String[]> commandLines = ArgumentCaptor.forClass(String[].class);
-    verify(spy).getProcess(any(), commandLines.capture());
+    ArgumentCaptor<String[]> commandLineCaptor = ArgumentCaptor.forClass(String[].class);
+    verify(spy).getProcess(any(), commandLineCaptor.capture());
 
-    String[] lines = commandLines.getValue();
-    assertThat(lines[12]).isEqualTo("--bind-address=127.0.0.1");
+    List<String> commandLine = Arrays.asList(commandLineCaptor.getValue());
+    String expectedBindAddressOption = "--bind-address=127.0.0.1";
+    assertThat(commandLine)
+        .containsOnlyOnce(LOCATOR_LAUNCHER_CLASS_NAME, expectedBindAddressOption)
+        .containsSubsequence(LOCATOR_LAUNCHER_CLASS_NAME, expectedBindAddressOption);
   }
 
   @Test
@@ -104,9 +111,13 @@ public void startLocatorRespectsHostnameForClients() throws Exception {
         .addOption("hostname-for-clients", FAKE_HOSTNAME).toString();
 
     commandRule.executeAndAssertThat(spy, startLocatorCommand);
-    ArgumentCaptor<String[]> commandLines = ArgumentCaptor.forClass(String[].class);
-    verify(spy).getProcess(any(), commandLines.capture());
-    String[] lines = commandLines.getValue();
-    assertThat(lines).containsOnlyOnce("--hostname-for-clients=" + FAKE_HOSTNAME);
+
+    ArgumentCaptor<String[]> commandLine = ArgumentCaptor.forClass(String[].class);
+    verify(spy).getProcess(any(), commandLine.capture());
+
+    String expectedHostNameOption = "--hostname-for-clients=" + FAKE_HOSTNAME;
+    assertThat(commandLine.getValue())
+        .containsOnlyOnce(LOCATOR_LAUNCHER_CLASS_NAME, expectedHostNameOption)
+        .containsSubsequence(LOCATOR_LAUNCHER_CLASS_NAME, expectedHostNameOption);
   }
 }

geode-assembly/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/StartServerCommandIntegrationTest.java

@@ -36,6 +36,8 @@
 
 public class StartServerCommandIntegrationTest {
   private static final String FAKE_HOSTNAME = "someFakeHostname";
+  private static final String SERVER_LAUNCHER_CLASS_NAME =
+      "org.apache.geode.distributed.ServerLauncher";
 
   @Rule
   public GfshParserRule commandRule = new GfshParserRule();
@@ -83,9 +85,12 @@ public void startServerRespectsHostnameForClients() throws Exception {
         .addOption("hostname-for-clients", FAKE_HOSTNAME).toString();
 
     commandRule.executeAndAssertThat(spy, startServerCommand);
-    ArgumentCaptor<String[]> commandLines = ArgumentCaptor.forClass(String[].class);
-    verify(spy).getProcess(any(), commandLines.capture());
-    String[] lines = commandLines.getValue();
-    assertThat(lines).containsOnlyOnce("--hostname-for-clients=" + FAKE_HOSTNAME);
+    ArgumentCaptor<String[]> commandLine = ArgumentCaptor.forClass(String[].class);
+    verify(spy).getProcess(any(), commandLine.capture());
+
+    String expectedHostNameOption = "--hostname-for-clients=" + FAKE_HOSTNAME;
+    assertThat(commandLine.getValue())
+        .containsOnlyOnce(SERVER_LAUNCHER_CLASS_NAME, expectedHostNameOption)
+        .containsSubsequence(SERVER_LAUNCHER_CLASS_NAME, expectedHostNameOption);
   }
 }