Skip to content

Commit 0548766

Browse files
authored
change aggregation temporality to DELTA instead of CUMULATIVE (#4111)
1 parent 4a4c171 commit 0548766

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/OpenTelemetryMetrics.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import io.opentelemetry.exporter.otlp.http.metrics.OtlpHttpMetricExporterBuilder;
3434
import io.opentelemetry.sdk.OpenTelemetrySdk;
3535
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
36+
import io.opentelemetry.sdk.metrics.export.AggregationTemporalitySelector;
3637
import io.opentelemetry.sdk.metrics.export.MetricExporter;
3738
import io.opentelemetry.sdk.metrics.export.PeriodicMetricReader;
3839
import io.opentelemetry.sdk.resources.Resource;
@@ -86,6 +87,7 @@ protected MetricExporter initializeMetricExporter(State state) {
8687
httpExporterBuilder.addHeader(header.getKey(), header.getValue());
8788
}
8889
}
90+
httpExporterBuilder.setAggregationTemporalitySelector(AggregationTemporalitySelector.deltaPreferred());
8991
return httpExporterBuilder.build();
9092
}
9193

gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/TemporalMetricsHelper.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333

3434
import io.micrometer.core.instrument.Clock;
3535
import io.micrometer.core.instrument.MeterRegistry;
36+
import io.micrometer.registry.otlp.AggregationTemporality;
3637
import io.micrometer.registry.otlp.OtlpConfig;
3738
import io.micrometer.registry.otlp.OtlpMeterRegistry;
3839
import io.temporal.common.reporter.MicrometerClientStatsReporter;
@@ -91,6 +92,12 @@ public String prefix() {
9192
return GobblinTemporalConfigurationKeys.TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT;
9293
}
9394

95+
@NotNull
96+
@Override
97+
public AggregationTemporality aggregationTemporality() {
98+
return AggregationTemporality.DELTA;
99+
}
100+
94101
@NotNull
95102
@Override
96103
public Map<String, String> headers() {

0 commit comments

Comments
 (0)