Skip to content

Commit cd1e492

Browse files
committed
Add shutdown in finally block
1 parent 7475e49 commit cd1e492

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

gobblin-temporal/src/main/java/org/apache/gobblin/temporal/cluster/GobblinTemporalTaskRunner.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
import com.typesafe.config.ConfigValueFactory;
5050

5151
import io.temporal.client.WorkflowClient;
52-
import io.temporal.serviceclient.WorkflowServiceStubs;
5352
import lombok.Getter;
5453
import lombok.Setter;
5554

gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/service/ManagedWorkflowServiceStubs.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,12 @@ public ManagedWorkflowServiceStubs(WorkflowServiceStubs serviceStubs) {
3939
@Override
4040
public void close() {
4141
try {
42-
workflowServiceStubs.getOptions().getMetricsScope().close();
43-
workflowServiceStubs.shutdown();
42+
try {
43+
workflowServiceStubs.getOptions().getMetricsScope().close();
44+
}
45+
finally {
46+
workflowServiceStubs.shutdown();
47+
}
4448
}
4549
catch (Exception e) {
4650
log.error("Exception occurred while closing ManagedWorkflowServiceStubs", e);

0 commit comments

Comments
 (0)