Skip to content

Commit 1ed250d

Browse files
authored
Merge pull request #14813 from apache/asset-pipeline-gradle-deprecations
Update to new asset pipeline coordinates
2 parents 30474bc + cc23307 commit 1ed250d

File tree

38 files changed

+109
-83
lines changed

38 files changed

+109
-83
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
*.swp
99
.DS_Store
1010
.classpath
11+
.assetcache
1112
.gradle
1213
.gradle/
1314
.idea

build.gradle

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,19 @@ allprojects {
5353
content { includeModule 'org.apache.grails', 'grails-bom' }
5454
}
5555
// mavenLocal() // Keep, this will be uncommented and used by CI (groovy-joint-workflow)
56-
maven { url = 'https://repo.grails.org/grails/restricted' }
5756
maven {
5857
url = 'https://repository.apache.org/content/groups/snapshots'
5958
content {
60-
includeVersionByRegex 'org[.]apache[.]((grails)|(groovy)).*', '.*','.*SNAPSHOT'
59+
includeVersionByRegex 'org[.]apache[.]((grails)|(groovy)).*', '.*', '.*-SNAPSHOT'
60+
}
61+
}
62+
maven {
63+
url = 'https://central.sonatype.com/repository/maven-snapshots'
64+
content {
65+
includeVersionByRegex 'cloud[.]wondrify', '.*', '.*-SNAPSHOT'
6166
}
6267
}
68+
maven { url = 'https://repo.grails.org/grails/restricted' }
6369
}
6470
}
6571

buildSrc/build.gradle

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,21 @@ compileJava.options.release = gradleProperties.javaVersion.toString().toInteger(
3131

3232
repositories {
3333
// mavenLocal()
34-
mavenCentral()
35-
gradlePluginPortal()
36-
maven { url = 'https://repo.grails.org/grails/restricted' }
3734
maven {
3835
url = 'https://repository.apache.org/content/groups/snapshots'
3936
content {
4037
includeVersionByRegex 'org[.]apache[.]((grails)|(groovy)).*', '.*','.*SNAPSHOT'
4138
}
4239
}
40+
maven {
41+
url = 'https://central.sonatype.com/repository/maven-snapshots'
42+
content {
43+
includeVersionByRegex 'cloud[.]wondrify', '.*', '.*-SNAPSHOT'
44+
}
45+
}
46+
maven { url = 'https://repo.grails.org/grails/restricted' }
47+
mavenCentral()
48+
gradlePluginPortal()
4349
}
4450

4551
dependencies {
@@ -48,7 +54,7 @@ dependencies {
4854
// Due to https://github.com/hierynomus/license-gradle-plugin/issues/161, spring must be excluded
4955
exclude group: 'org.springframework', module: 'spring-core'
5056
}
51-
implementation 'com.bertramlabs.plugins:asset-pipeline-gradle'
57+
implementation 'cloud.wondrify:asset-pipeline-gradle'
5258
implementation 'io.github.gradle-nexus:publish-plugin'
5359
implementation 'org.apache.grails:grails-docs-core'
5460
implementation 'org.apache.grails:grails-gradle-plugins'

dependencies.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ ext {
2525
'ant.version' : '1.10.15',
2626
'asciidoctor-gradle-jvm.version' : '4.0.4',
2727
'asciidoctorj.version' : '3.0.0',
28-
'asset-pipeline-gradle.version' : '5.0.9',
28+
'asset-pipeline-gradle.version' : '5.0.10-SNAPSHOT',
2929
'byte-buddy.version' : '1.15.5',
3030
'commons-text.version' : '1.12.0',
3131
'directory-watcher.version' : '0.18.0',
@@ -58,7 +58,7 @@ ext {
5858
'ant-junit' : "org.apache.ant:ant-junit:${gradleBomDependencyVersions['ant.version']}",
5959
'asciidoctorj-gradle-jvm' : "org.asciidoctor:asciidoctor-gradle-jvm:${gradleBomDependencyVersions['asciidoctor-gradle-jvm.version']}",
6060
'asciidoctorj' : "org.asciidoctor:asciidoctorj:${gradleBomDependencyVersions['asciidoctorj.version']}",
61-
'asset-pipeline-gradle' : "com.bertramlabs.plugins:asset-pipeline-gradle:${gradleBomDependencyVersions['asset-pipeline-gradle.version']}",
61+
'asset-pipeline-gradle' : "cloud.wondrify:asset-pipeline-gradle:${gradleBomDependencyVersions['asset-pipeline-gradle.version']}",
6262
'byte-buddy' : "net.bytebuddy:byte-buddy:${gradleBomDependencyVersions['byte-buddy.version']}",
6363
'commons-text' : "org.apache.commons:commons-text:${gradleBomDependencyVersions['commons-text.version']}",
6464
'directory-watcher' : "io.methvin:directory-watcher:${gradleBomDependencyVersions['directory-watcher.version']}",
@@ -77,7 +77,7 @@ ext {
7777
]
7878

7979
bomDependencyVersions = [
80-
'asset-pipeline-grails.version': '5.0.9',
80+
'asset-pipeline-grails.version': '5.0.10-SNAPSHOT',
8181
'bootstrap-icons.version' : '1.11.3',
8282
'bootstrap.version' : '5.3.3',
8383
'commons-codec.version' : '1.17.1',
@@ -105,7 +105,7 @@ ext {
105105

106106
// Note: the name of the dependency must be the prefix of the property name so properties in the pom are resolved correctly
107107
bomDependencies = [
108-
'asset-pipeline-grails' : "com.bertramlabs.plugins:asset-pipeline-grails:${bomDependencyVersions['asset-pipeline-grails.version']}",
108+
'asset-pipeline-grails' : "cloud.wondrify:asset-pipeline-grails:${bomDependencyVersions['asset-pipeline-grails.version']}",
109109
'bootstrap' : "org.webjars.npm:bootstrap:${bomDependencyVersions['bootstrap.version']}",
110110
'bootstrap-icons' : "org.webjars.npm:bootstrap-icons:${bomDependencyVersions['bootstrap-icons.version']}",
111111
'commons-codec' : "commons-codec:commons-codec:${bomDependencyVersions['commons-codec.version']}",

gradle/hibernate5-test-config.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ tasks.withType(Test).configureEach {
3737

3838
useJUnitPlatform()
3939
systemProperty('hibernate5.gorm.suite', System.getProperty('hibernate5.gorm.suite') ?: true)
40-
reports.html.required = !System.getenv('CI')
41-
reports.junitXml.required = !System.getenv('CI')
40+
reports.html.required = !isCiBuild
41+
reports.junitXml.required = !isCiBuild
4242
testLogging {
4343
events('passed', 'skipped', 'failed')
4444
showExceptions = true

grails-bom/build.gradle

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,16 +101,20 @@ tasks.register('extractConstraints', ExtractDependenciesTask).configure { Extrac
101101
it.destination = project.layout.buildDirectory.file('grails-bom-constraints.adoc')
102102
it.platformDefinitions = combinedPlatforms
103103
it.definitions = combinedDependencies
104+
it.projectName = project.name
104105
it.versions = combinedVersions
105-
Map<String, String> artifactIdMappings = [:]
106106
rootProject.subprojects.each { p ->
107107
evaluationDependsOn(p.path)
108-
String artifactId = p.findProperty('pomArtifactId')
109-
if(artifactId) {
110-
artifactIdMappings[p.name] = artifactId
111-
}
112108
}
113-
it.projectArtifactIds.set(artifactIdMappings)
109+
it.projectArtifactIds.set(project.provider{
110+
Map<String, String> artifactIdMappings = [:]
111+
112+
rootProject.subprojects.each { p ->
113+
artifactIdMappings[p.name] = p.findProperty('pomArtifactId') ?: p.name
114+
}
115+
116+
artifactIdMappings
117+
})
114118

115119
it.dependsOn(project.tasks.named('generateMetadataFileForMavenPublication'), project.tasks.named('generatePomFileForMavenPublication'))
116120
}

grails-data-neo4j/examples/grails3-neo4j-hibernate/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ dependencies {
4141
developmentOnly platform(project(':grails-bom'))
4242
developmentOnly 'org.webjars.npm:jquery'
4343

44-
runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails:$assetPipelineVersion"
44+
runtimeOnly "cloud.wondrify:asset-pipeline-grails:$assetPipelineVersion"
4545
runtimeOnly "org.apache.grails:grails-scaffolding:$scaffoldingVersion"
4646
runtimeOnly "org.apache.grails:grails-fields:$fieldsVersion"
4747
runtimeOnly "org.apache.tomcat:tomcat-jdbc:9.0.36"

grails-data-neo4j/examples/grails3-neo4j/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ dependencies {
3939
developmentOnly platform(project(':grails-bom'))
4040
developmentOnly 'org.webjars.npm:jquery'
4141

42-
runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails:$assetPipelineVersion"
42+
runtimeOnly "cloud.wondrify:asset-pipeline-grails:$assetPipelineVersion"
4343
runtimeOnly "org.apache.grails:grails-scaffolding:$scaffoldingVersion"
4444
runtimeOnly "org.apache.grails:grails-fields:$fieldsVersion"
4545

grails-doc/src/en/guide/commandLine/gradleBuild/gradleDependencies.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ dependencies {
4848
implementation "org.springframework.boot:spring-boot-starter-tomcat"
4949
implementation "org.springframework.boot:spring-boot-starter-validation"
5050
console "org.apache.grails:grails-console"
51-
runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails"
51+
runtimeOnly "cloud.wondrify:asset-pipeline-grails"
5252
runtimeOnly "com.h2database:h2"
5353
runtimeOnly "com.zaxxer:HikariCP"
5454
runtimeOnly "org.fusesource.jansi:jansi"

grails-doc/src/en/guide/commandLine/gradleBuild/gradlePlugins.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ plugins {
3535
id "eclipse"
3636
}
3737
38-
apply plugin: "asset-pipeline"
38+
apply plugin: "cloud.wondrify.asset-pipeline"
3939
apply plugin: "org.apache.grails.gradle.grails-web"
4040
apply plugin: "org.apache.grails.gradle.grails-gsp"
4141
----

0 commit comments

Comments
 (0)