Skip to content

Commit 1f24d11

Browse files
author
graeme
committed
fix for failing test, changed some references to Invoker to use GroovySystem.metaClassRegistry instead
git-svn-id: https://svn.codehaus.org/grails/trunk@6277 1cfb16fd-6d17-0410-8ff1-b7e8e1e2867d
1 parent a8cf8f4 commit 1f24d11

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

src/commons/org/codehaus/groovy/grails/commons/GrailsMetaClassUtils.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import groovy.lang.*;
1818
import org.apache.commons.logging.Log;
1919
import org.apache.commons.logging.LogFactory;
20-
import org.codehaus.groovy.runtime.InvokerHelper;
2120
import org.codehaus.groovy.runtime.metaclass.ThreadManagedMetaBeanProperty;
2221
import org.springframework.beans.BeanUtils;
2322

@@ -45,7 +44,7 @@ public class GrailsMetaClassUtils {
4544
* @return The registry
4645
*/
4746
public static MetaClassRegistry getRegistry() {
48-
return InvokerHelper.getInstance().getMetaRegistry();
47+
return GroovySystem.getMetaClassRegistry();
4948
}
5049

5150
/**

src/commons/org/codehaus/groovy/grails/commons/metaclass/ProxyMetaClass.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
*/
1515
package org.codehaus.groovy.grails.commons.metaclass;
1616

17-
import org.codehaus.groovy.runtime.InvokerHelper;
18-
1917
import groovy.lang.*;
2018

2119
import java.beans.IntrospectionException;
@@ -60,7 +58,7 @@ public void setAdaptee(MetaClass adaptee) {
6058
* @throws java.beans.IntrospectionException When the class canot be introspected
6159
*/
6260
public static ProxyMetaClass getInstance(Class theClass) throws IntrospectionException {
63-
MetaClassRegistry metaRegistry = InvokerHelper.getInstance().getMetaRegistry();
61+
MetaClassRegistry metaRegistry = GroovySystem.getMetaClassRegistry();
6462
MetaClass meta = metaRegistry.getMetaClass(theClass);
6563
ProxyMetaClass pmc = new ProxyMetaClass(metaRegistry, theClass, meta);
6664
pmc.initialize();

src/persistence/org/codehaus/groovy/grails/orm/hibernate/GrailsHibernateDomainClass.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
*/
1515
package org.codehaus.groovy.grails.orm.hibernate;
1616

17+
import groovy.lang.GroovySystem;
1718
import groovy.lang.MetaClass;
1819
import groovy.lang.MetaClassRegistry;
1920
import org.apache.commons.logging.Log;
@@ -27,7 +28,6 @@
2728
import org.codehaus.groovy.grails.commons.metaclass.ProxyMetaClass;
2829
import org.codehaus.groovy.grails.validation.GrailsDomainClassValidator;
2930
import org.codehaus.groovy.grails.validation.metaclass.ConstraintsEvaluatingDynamicProperty;
30-
import org.codehaus.groovy.runtime.InvokerHelper;
3131
import org.hibernate.EntityMode;
3232
import org.hibernate.MappingException;
3333
import org.hibernate.SessionFactory;
@@ -155,7 +155,7 @@ private void evaluateConstraints() {
155155
};
156156

157157
interceptor.addDynamicProperty(new ConstraintsEvaluatingDynamicProperty());
158-
MetaClassRegistry metaRegistry = InvokerHelper.getInstance().getMetaRegistry();
158+
MetaClassRegistry metaRegistry = GroovySystem.getMetaClassRegistry();
159159
MetaClass meta = metaRegistry.getMetaClass(instance.getClass());
160160

161161
try {

src/web/org/codehaus/groovy/grails/web/binding/GrailsDataBinder.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,10 +263,8 @@ protected void autoCreateIfPossible(MutablePropertyValues mpvs) {
263263
if(bean.getPropertyValue(propertyName) == null) {
264264
if(bean.isWritableProperty(propertyName)) {
265265
try {
266-
MetaClass mc = InvokerHelper
267-
.getInstance()
268-
.getMetaRegistry()
269-
.getMetaClass(type);
266+
MetaClass mc = GroovySystem.getMetaClassRegistry()
267+
.getMetaClass(type);
270268
if(mc!=null) {
271269
Object created = mc.invokeStaticMethod(type,CreateDynamicMethod.METHOD_NAME, new Object[0]);
272270
bean.setPropertyValue(propertyName,created);

test/commons/org/codehaus/groovy/grails/validation/ConstraintsEvaluatingPropertyTests.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import groovy.lang.GroovyClassLoader;
44
import junit.framework.TestCase;
55
import org.codehaus.groovy.grails.commons.DefaultGrailsDomainClass;
6+
import org.codehaus.groovy.grails.commons.GrailsDomainClass;
67
import org.codehaus.groovy.grails.validation.metaclass.ConstraintsEvaluatingDynamicProperty;
78

89
import java.util.Collection;
@@ -17,10 +18,14 @@ public void testGet() throws Exception {
1718
GroovyClassLoader gcl = new GroovyClassLoader();
1819
Class groovyClass = gcl.parseClass("package org.codehaus.groovy.grails.validation\n" +
1920
"class Test {\n" +
21+
" Long id\n"+ // WE NEED this even though GORM 2 doesn't, as we're not a "domain" class within grails-app
22+
" Long version\n"+ // WE NEED this even though GORM 2 doesn't, as we're not a "domain" class within grails-app
2023
" String name\n" +
2124
"}");
2225

23-
ConstraintsEvaluatingDynamicProperty cp = new ConstraintsEvaluatingDynamicProperty();
26+
GrailsDomainClass domainClass = new DefaultGrailsDomainClass(groovyClass);
27+
28+
ConstraintsEvaluatingDynamicProperty cp = new ConstraintsEvaluatingDynamicProperty(domainClass.getPersistentProperties());
2429

2530
Map constraints = (Map)cp.get(groovyClass.newInstance());
2631

@@ -138,7 +143,7 @@ public void testInheritedConstraints() throws Exception {
138143
" name( size:5..20)\n" +
139144
" }" +
140145
"}";
141-
ensureConstraintsPresent(new String[] { classSource, descendentSource}, 1, 3); // Must have nullable and validator
146+
ensureConstraintsPresent(new String[] { classSource, descendentSource}, 1, 2); // Must have nullable and validator
142147
}
143148

144149
private void ensureConstraintsPresent(String[] classSource, int classIndexToTest, int constraintCount)

0 commit comments

Comments
 (0)