Skip to content

Commit 2f409b5

Browse files
authored
Merge pull request #10355 from grails/GRAILS-10312
Grails 10312
2 parents 32cb9dc + f75c764 commit 2f409b5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

grails-plugin-controllers/src/main/groovy/grails/artefact/controller/support/ResponseRenderer.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ trait ResponseRenderer extends WebAttributes {
393393
hasContentType = detectContentTypeFromFileName(webRequest, response, argMap, fileName)
394394
}
395395
if (fnO) {
396-
response.setHeader HttpHeaders.CONTENT_DISPOSITION, DISPOSITION_HEADER_PREFIX + fileName
396+
response.setHeader HttpHeaders.CONTENT_DISPOSITION, "$DISPOSITION_HEADER_PREFIX\"$fileName\""
397397
}
398398
}
399399
if (!hasContentType) {

grails-test-suite-uber/src/test/groovy/org/grails/web/servlet/RenderMethodTests.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class RenderMethodTests {
5454

5555
controller.render file:new ByteArrayInputStream("hello".bytes), contentType:"text/plain", fileName:"hello.txt"
5656
assert "hello" == response.contentAsString
57-
assert "attachment;filename=hello.txt" == response.getHeader(HttpHeaders.CONTENT_DISPOSITION)
57+
assert "attachment;filename=\"hello.txt\"" == response.getHeader(HttpHeaders.CONTENT_DISPOSITION)
5858
}
5959

6060
@Test

0 commit comments

Comments
 (0)