interceptor methods should be private

 This should fix the failing JDK8 joint build test.  The issue is that since these methods were public they were being configured as controller actions.  This happened to work ok with JDK7 and not work with JDK8 because of a difference in the ordering of AST transformation classes at compile time.

 When a controller is compiled with JDK7, the getRequest method that we add to that controller looks like this...

    public HttpServletRequest getRequest() {
        return this.instanceControllerTagLibraryApi.getRequest(this);
    }

When that same controller is compiled with JDK8 that method looks like this...

    public HttpServletRequest getRequest() {
        return this.instanceControllersRestApi.getRequest(this);
    }

instanceControllerTagLibraryApi is initialized in the constructor.  instanceControllersRestApi is not, at least not directly.  I think it relies on injection from the app context and that bean doesn't exist when that particular failing test is run.

Since these methods were being configured as controller action methods code was being added to them to access the request in order to do allowedMethods checking.  Because instanceControllersRestApi is used when the controller is compiled with JDK8 and that property is null for this particular test, the test was failing.

Author: jeffscottbrown

grails-test-suite-uber/src/test/groovy/org/codehaus/groovy/grails/commons/DefaultGrailsControllerClass2Tests.java

@@ -143,7 +143,7 @@ public void testInterceptors() throws Exception {
         GroovyClassLoader cl = new GrailsAwareClassLoader();
         Class<?> clazz = cl.parseClass("@grails.artefact.Artefact(\"Controller\") class TestController { \n" +
                                         "def beforeInterceptor = [action:this.&before,only:'list']\n" +
-                                        "def before() { return 'success' }\n" +
+                                        "private before() { return 'success' }\n" +
                                         "def list = { return 'test' }\n " +
                                         "} ");
         GrailsControllerClass grailsClass = new DefaultGrailsControllerClass(clazz);
@@ -159,7 +159,7 @@ public void testInterceptors() throws Exception {
 
         clazz = cl.parseClass("@grails.artefact.Artefact(\"Controller\") class AfterController { \n" +
                 "def afterInterceptor = [action:this.&before,except:'list']\n" +
-                "def after() { return 'success' }\n" +
+                "private after() { return 'success' }\n" +
                 "def list = { return 'test' }\n " +
                 "def save = { return 'test' }\n " +
             "} ");
@@ -175,7 +175,7 @@ public void testBeforeInterceptorWithNoExcept() {
         GroovyClassLoader cl = new GrailsAwareClassLoader();
         Class<?> clazz = cl.parseClass("@grails.artefact.Artefact(\"Controller\") class TestController { \n" +
                                         "def beforeInterceptor = [action:this.&before]\n" +
-                                        "def before() { return 'success' }\n" +
+                                        "private before() { return 'success' }\n" +
                                         "def list = { return 'test' }\n " +
                                         "def show = { return 'test' }\n " +
                                         "} ");