test: remove @PendingFeature for passing tests

Author: matrei

grails-async/core/src/test/groovy/grails/async/FutureTaskPromiseFactorySpec.groovy

@@ -21,7 +21,6 @@ package grails.async
 import grails.async.decorator.PromiseDecorator
 import org.grails.async.factory.future.CachedThreadPoolPromiseFactory
 import spock.lang.Issue
-import spock.lang.PendingFeatureIf
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -100,10 +99,6 @@ class FutureTaskPromiseFactorySpec extends Specification {
             hasError == false
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise onError handling'() {
 
         when: 'a promise is executed with an onComplete handler'
@@ -138,10 +133,6 @@ class FutureTaskPromiseFactorySpec extends Specification {
            val == 10
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise chaining with exception'() {
 
         when: 'a promise is chained'
@@ -155,10 +146,6 @@ class FutureTaskPromiseFactorySpec extends Specification {
     }
 
     @Issue('GRAILS-10152')
-    @PendingFeatureIf({
-        // Mock() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise closure is not executed multiple times if it returns null'() {
 
         given: 'a closure that returns null'

grails-async/core/src/test/groovy/grails/async/PromiseListSpec.groovy

@@ -18,7 +18,6 @@
  */
 package grails.async
 
-import spock.lang.PendingFeatureIf
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -74,10 +73,6 @@ class PromiseListSpec extends Specification {
 
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise list with an exception'() {
 
         when: 'a promise list with a promise that throws an exception is used'

grails-async/core/src/test/groovy/grails/async/PromiseSpec.groovy

@@ -44,10 +44,6 @@ class PromiseSpec extends Specification {
 
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise timeout handling'() {
 
         when: 'a promise that takes a while is created'
@@ -165,10 +161,6 @@ class PromiseSpec extends Specification {
             result == 10
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise chaining with exception'() {
 
         when: 'a promise is chained'

grails-async/core/src/test/groovy/grails/async/SynchronousPromiseFactorySpec.groovy

@@ -21,7 +21,6 @@ package grails.async
 import grails.async.decorator.PromiseDecorator
 import org.grails.async.factory.SynchronousPromiseFactory
 import spock.lang.Issue
-import spock.lang.PendingFeatureIf
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -128,10 +127,6 @@ class SynchronousPromiseFactorySpec extends Specification {
             result == 10
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise chaining with exception'() {
 
         when: 'a promise is chained'
@@ -145,10 +140,6 @@ class SynchronousPromiseFactorySpec extends Specification {
     }
 
     @Issue('GRAILS-9229')
-    @PendingFeatureIf({
-        // Mock() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise is executed without calling get'() {
 
         given: 'a closure'
@@ -162,10 +153,6 @@ class SynchronousPromiseFactorySpec extends Specification {
     }
 
     @Issue('GRAILS-10152')
-    @PendingFeatureIf({
-        // Mock() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise closure is not executed multiple times if it returns null'() {
 
         given: 'a closure that returns null'

grails-async/gpars/src/test/groovy/grails/async/GparsPromiseSpec.groovy

@@ -20,7 +20,6 @@ package grails.async
 
 import grails.async.decorator.PromiseDecorator
 import org.grails.async.factory.gpars.GparsPromiseFactory
-import spock.lang.PendingFeatureIf
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -49,10 +48,6 @@ class GparsPromiseSpec extends Specification {
             result == '*10*'
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise timeout handling'() {
 
         when: 'a promise that takes longer than the timeout'
@@ -147,10 +142,6 @@ class GparsPromiseSpec extends Specification {
             value == 10
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise chaining with exception'() {
 
         when: 'a promise with an exception is chained'

grails-async/plugin/src/test/groovy/grails/async/services/WebPromisesSpec.groovy

@@ -22,18 +22,13 @@ import grails.async.Promises
 import grails.async.web.WebPromises
 import grails.util.GrailsWebMockUtil
 import org.springframework.web.context.request.RequestContextHolder
-import spock.lang.PendingFeatureIf
 import spock.lang.Specification
 
 /**
  * Created by graemerocher on 20/02/2017.
  */
 class WebPromisesSpec extends Specification {
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test web promises handling'() {
 
         setup:

grails-async/rxjava/src/test/groovy/org/grails/async/factory/rxjava/RxJavaPromiseListSpec.groovy

@@ -19,7 +19,6 @@
 package org.grails.async.factory.rxjava
 
 import grails.async.PromiseList
-import spock.lang.PendingFeatureIf
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -78,10 +77,6 @@ class RxJavaPromiseListSpec extends Specification{
             result == [1,2,3]
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise list with an exception'() {
 
         given: 'a promise list with a promise that throws an exception'

grails-async/rxjava/src/test/groovy/org/grails/async/factory/rxjava/RxJavaPromiseSpec.groovy

@@ -20,7 +20,6 @@ package org.grails.async.factory.rxjava
 
 import grails.async.Promises
 import grails.async.decorator.PromiseDecorator
-import spock.lang.PendingFeatureIf
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -49,10 +48,6 @@ class RxJavaPromiseSpec extends Specification {
 
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise timeout handling'() {
 
         when: 'a promise that takes a while is created'
@@ -146,10 +141,6 @@ class RxJavaPromiseSpec extends Specification {
             val == 10
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise chaining with exception'() {
 
         when: 'a promise is chained'

grails-async/rxjava2/src/test/groovy/org/grails/async/factory/rxjava2/RxPromiseListSpec.groovy

@@ -19,7 +19,6 @@
 package org.grails.async.factory.rxjava2
 
 import grails.async.PromiseList
-import spock.lang.PendingFeatureIf
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -78,10 +77,6 @@ class RxPromiseListSpec extends Specification {
 
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise list with an exception'() {
 
         given: 'a promise list with a promise that throws an exception'

grails-async/rxjava2/src/test/groovy/org/grails/async/factory/rxjava2/RxPromiseSpec.groovy

@@ -20,7 +20,6 @@ package org.grails.async.factory.rxjava2
 
 import grails.async.Promises
 import grails.async.decorator.PromiseDecorator
-import spock.lang.PendingFeatureIf
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -49,10 +48,6 @@ class RxPromiseSpec extends Specification {
 
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise timeout handling'() {
 
         when: 'a promise that takes a while is created'
@@ -159,10 +154,6 @@ class RxPromiseSpec extends Specification {
             value == 10
     }
 
-    @PendingFeatureIf({
-        // thrown() does currently not work with Groovy 5
-        GroovySystem.version.startsWith('5')
-    })
     void 'Test promise chaining with exception'() {
 
         when: 'a promise is chained'