Fix and test for GRAILS-8925

Author: lhotari

grails-test-suite-web/src/test/groovy/org/codehaus/groovy/grails/web/taglib/ApplicationTagLibTests.groovy

@@ -183,6 +183,12 @@ class ApplicationTagLibTests extends AbstractGrailsTagTests {
         assertOutputEquals('', template, [c:[:]])
         assertOutputEquals('foo', template, [c:[a:[b:'foo']]])
     }
+    
+    void testSetTagWithScope() {
+        def template = '<g:set var="var1" value="1"/>${var1}<g:set var="var1" value="2"/> ${var1}<g:set var="var2" value="3" scope="request"/> ${var2}<g:set var="var2" value="4" scope="request"/> ${var2}'
+        assertOutputEquals('1 2 3 4', template)
+    }
+    
 
     void testIteration() {
         def template = '''<g:set var="counter" value="${1}" />

grails-web/src/main/groovy/org/codehaus/groovy/grails/web/pages/GroovyPageBinding.java

@@ -37,6 +37,8 @@ public class GroovyPageBinding extends AbstractGroovyPageBinding {
     private Binding parent;
     private GroovyPage owner;
     private Set<String> cachedParentVariableNames=new HashSet<String>();
+    private GroovyPageRequestBinding pageRequestBinding;
+    private boolean pageRequestBindingInitialized=false;
     private boolean root;
 
     public GroovyPageBinding() {
@@ -64,6 +66,24 @@ public GroovyPageBinding(String[] args) {
     public Object getProperty(String property) {
         return getVariable(property);
     }
+    
+    private GroovyPageRequestBinding findPageRequestBinding() {
+        if(!pageRequestBindingInitialized && parent != null) {
+            Binding nextParent = parent;
+            while(nextParent != null && pageRequestBinding==null) {
+                if(nextParent instanceof GroovyPageRequestBinding) {
+                    pageRequestBinding = (GroovyPageRequestBinding)nextParent;
+                }
+                if (nextParent instanceof GroovyPageBinding) {
+                    nextParent = ((GroovyPageBinding)nextParent).parent;
+                } else {
+                    nextParent = null;
+                }
+            }
+            pageRequestBindingInitialized=true;
+        }
+        return pageRequestBinding;
+    }
 
     @SuppressWarnings("unchecked")
     @Override
@@ -76,9 +96,11 @@ public Object getVariable(String name) {
             if (parent != null) {
                 val = parent.getVariable(name);
                 if (val != null) {
-                    // cache variable in this context since parent context cannot change during usage of this context
-                    getVariablesMap().put(name, val);
-                    cachedParentVariableNames.add(name);
+                    if(findPageRequestBinding()==null || !findPageRequestBinding().isRequestAttributeVariable(name)) {
+                        // cache variable in this context since parent context cannot change during usage of this context
+                        getVariablesMap().put(name, val);
+                        cachedParentVariableNames.add(name);
+                    }
                 }
             }
         }

grails-web/src/main/groovy/org/codehaus/groovy/grails/web/pages/GroovyPageRequestBinding.java

@@ -38,6 +38,7 @@ public class GroovyPageRequestBinding extends AbstractGroovyPageBinding {
     private GrailsWebRequest webRequest;
     private Map<String, Class<?>> cachedDomainsWithoutPackage;
     private boolean developmentMode = Environment.isDevelopmentMode();
+    private Set<String> requestAttributeVariables=new HashSet<String>();
 
     private static Map<String, LazyRequestBasedValue> lazyRequestBasedValuesMap = new HashMap<String, LazyRequestBasedValue>();
     static {
@@ -113,28 +114,33 @@ public GroovyPageRequestBinding(GrailsWebRequest webRequest) {
             }
         }
     }
+    
+    public boolean isRequestAttributeVariable(String name) {
+        return requestAttributeVariables.contains(name);
+    }
 
     @Override
     public Object getVariable(String name) {
         Object val = getVariablesMap().get(name);
         if (val == null && !getVariablesMap().containsKey(name) && webRequest != null) {
             val = webRequest.getCurrentRequest().getAttribute(name);
-
-            if (val == null) {
+            if(val != null) {
+                requestAttributeVariables.add(name);
+            } else {
                 LazyRequestBasedValue lazyValue = lazyRequestBasedValuesMap.get(name);
                 if (lazyValue != null) {
                     val = lazyValue.evaluate(webRequest);
                 }
-            }
-
-            if (val == null && cachedDomainsWithoutPackage != null) {
-                val = cachedDomainsWithoutPackage.get(name);
-            }
-
-            // warn about missing variables in development mode
-            if (val == null && developmentMode) {
-                if (log.isDebugEnabled()) {
-                    log.debug("Variable '" + name + "' not found in binding or the value is null.");
+    
+                if (val == null && cachedDomainsWithoutPackage != null) {
+                    val = cachedDomainsWithoutPackage.get(name);
+                }
+    
+                // warn about missing variables in development mode
+                if (val == null && developmentMode) {
+                    if (log.isDebugEnabled()) {
+                        log.debug("Variable '" + name + "' not found in binding or the value is null.");
+                    }
                 }
             }
         }