Profile - print an error if an application profile is used to create a plugin. Relates to #9849

Currently Grails allows application profiles to be used with the `create-plugin` command. This change disallows that by printing an error and exiting if an application profile is used.

Author: graemerocher

grails-shell/src/main/groovy/org/grails/cli/profile/commands/CreateAppCommand.groovy

@@ -137,8 +137,7 @@ class CreateAppCommand extends ArgumentCompletingCommand implements ProfileRepos
         def profileName = evaluateProfileName(mainCommandLine)
 
         Profile profileInstance = profileRepository.getProfile(profileName)
-        if(profileInstance == null) {
-            executionContext.console.error("Profile not found for name [$profileName]")
+        if( !validateProfile(profileInstance, profileName, executionContext)) {
             return false
         }
         List<Feature> features = evaluateFeatures(profileInstance, mainCommandLine).toList()
@@ -202,6 +201,14 @@ class CreateAppCommand extends ArgumentCompletingCommand implements ProfileRepos
         }
     }
 
+    protected boolean validateProfile(Profile profileInstance, String profileName, ExecutionContext executionContext) {
+        if (profileInstance == null) {
+            executionContext.console.error("Profile not found for name [$profileName]")
+            return false
+        }
+        return true
+    }
+
     private Map<URL, File> unzippedDirectories = new LinkedHashMap<URL, File>()
     @CompileDynamic
     protected File unzipProfile(AntBuilder ant, Resource location) {

grails-shell/src/main/groovy/org/grails/cli/profile/commands/CreatePluginCommand.groovy

@@ -18,6 +18,8 @@ package org.grails.cli.profile.commands
 
 import groovy.transform.CompileStatic
 import org.grails.build.parsing.CommandLine
+import org.grails.cli.profile.ExecutionContext
+import org.grails.cli.profile.Profile
 
 
 /**
@@ -48,5 +50,16 @@ class CreatePluginCommand extends CreateAppCommand {
     @Override
     protected String getDefaultProfile() { "web-plugin" }
 
+    @Override
+    protected boolean validateProfile(Profile profileInstance, String profileName, ExecutionContext executionContext) {
 
+        def pluginProfile = profileInstance.extends.find() { Profile parent -> parent.name == 'plugin' }
+        if(pluginProfile == null) {
+            executionContext.console.error("No valid plugin profile found for name [$profileName]")
+            return false
+        }
+        else {
+            return super.validateProfile(profileInstance, profileName, executionContext)
+        }
+    }
 }