Skip to content

Commit 5a83113

Browse files
committed
Merge branch '3.0.x' into 3.1.x
2 parents ad5437e + 9ebaef3 commit 5a83113

File tree

1 file changed

+11
-27
lines changed

1 file changed

+11
-27
lines changed

grails-web-url-mappings/src/main/groovy/org/grails/web/mapping/mvc/AbstractGrailsControllerUrlMappings.groovy

Lines changed: 11 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -134,40 +134,24 @@ abstract class AbstractGrailsControllerUrlMappings implements UrlMappings{
134134
def plugin = hasUrlConverter ? urlConverter.toUrlElement( controller.pluginName ) : controller.pluginName
135135
def controllerName = hasUrlConverter ? urlConverter.toUrlElement( controller.logicalPropertyName ) : controller.logicalPropertyName
136136
String pluginNameToRegister = plugin ? GrailsNameUtils.getPropertyNameForLowerCaseHyphenSeparatedName(plugin) : null
137-
final boolean hasNamespace = namespace == null
138-
if(!hasNamespace) {
139-
mappingsToGrailsControllerMap.put(new ControllerKey(namespace, controllerName, null, plugin), controller)
140-
if(plugin) {
141-
mappingsToGrailsControllerMap.put(new ControllerKey(namespace, controllerName, null, pluginNameToRegister), controller)
142-
def controllerKeyWithoutPlugin = new ControllerKey(namespace, controllerName, null, null)
143-
if(!mappingsToGrailsControllerMap.containsKey(controllerKeyWithoutPlugin)) {
144-
mappingsToGrailsControllerMap.put(controllerKeyWithoutPlugin, controller)
145-
}
146-
}
147-
}
148-
149-
150-
def noNamespaceNoPluginKey = new ControllerKey(null, controllerName, null, null)
151-
def noNamespaceDefaultActionKey = new ControllerKey(null, controllerName, null, plugin)
137+
final boolean hasNamespace = namespace != null
152138

139+
def defaultActionKey = new ControllerKey(namespace, controllerName, null, pluginNameToRegister)
140+
def noPluginDefaultActionKey = new ControllerKey(namespace, controllerName, null, null)
141+
def noNamespaceDefaultActionKey = new ControllerKey(null, controllerName, null, pluginNameToRegister)
142+
def noNamespaceNoPluginDefaultActionKey = new ControllerKey(null, controllerName, null, null)
153143

154-
if(hasNamespace) {
155-
mappingsToGrailsControllerMap.put(noNamespaceNoPluginKey, controller)
144+
mappingsToGrailsControllerMap.put(defaultActionKey, controller)
145+
if(hasNamespace && !mappingsToGrailsControllerMap.containsKey(noNamespaceDefaultActionKey)) {
156146
mappingsToGrailsControllerMap.put(noNamespaceDefaultActionKey, controller)
157147
}
158-
else {
159-
if(!mappingsToGrailsControllerMap.containsKey(noNamespaceNoPluginKey)) {
160-
mappingsToGrailsControllerMap.put(noNamespaceNoPluginKey, controller)
161-
}
162-
if(!mappingsToGrailsControllerMap.containsKey(noNamespaceDefaultActionKey)) {
163-
mappingsToGrailsControllerMap.put(noNamespaceDefaultActionKey, controller)
148+
if(plugin != null && !mappingsToGrailsControllerMap.containsKey(noPluginDefaultActionKey)) {
149+
mappingsToGrailsControllerMap.put(noPluginDefaultActionKey, controller)
150+
if(hasNamespace && !mappingsToGrailsControllerMap.containsKey(noNamespaceNoPluginDefaultActionKey)) {
151+
mappingsToGrailsControllerMap.put(noNamespaceNoPluginDefaultActionKey, controller)
164152
}
165153
}
166154

167-
168-
169-
170-
171155
for(action in controller.actions) {
172156
action = hasUrlConverter ? urlConverter.toUrlElement(action) : action
173157
def withPluginKey = new ControllerKey(namespace, controllerName, action, pluginNameToRegister)

0 commit comments

Comments
 (0)