Merged fix for GRAILS-4344 which also fixes GRAILS-5426 "HibernatePluginSupport.#addValidationMethods(...) is reason of memory leak"

Author: graemerocher

src/groovy/org/codehaus/groovy/grails/orm/hibernate/support/ClosureEventTriggeringInterceptor.groovy

@@ -135,6 +135,9 @@ class ClosureEventTriggeringInterceptor extends SaveOrUpdateEventListener implem
             entity."$property.name" = now
         }
 
+        if(!entity.validate(deepValidate:false)) {
+            result = true
+        }
         return result
     }
 

src/groovy/org/codehaus/groovy/grails/plugins/DomainClassGrailsPlugin.groovy

@@ -33,7 +33,7 @@ class DomainClassGrailsPlugin {
 
 	def version = grails.util.GrailsUtil.getGrailsVersion()
 	def dependsOn = [i18n:version]
-	def loadAfter = ['hibernate', 'controllers']
+	def loadAfter = ['controllers']
 
 	def doWithSpring = {
 		for(dc in application.domainClasses) {

src/groovy/org/codehaus/groovy/grails/plugins/orm/hibernate/HibernatePluginSupport.groovy

@@ -394,14 +394,6 @@ Try using Grails' default cache provider: 'org.hibernate.cache.OSCacheProvider'"
         Validator validator = ctx.containsBean("${dc.fullName}Validator") ? ctx.getBean("${dc.fullName}Validator") : null
         def validateMethod = new ValidatePersistentMethod(sessionFactory, application.classLoader, application,validator)
 
-        MetaProperty originalPropertiesProperty = metaClass.getMetaProperty("properties")
-        metaClass.setProperties = {Object o ->
-            originalPropertiesProperty.setProperty delegate, o
-            if(delegate.hasErrors()) {
-                GrailsHibernateUtil.setObjectToReadyOnly delegate,sessionFactory
-            }
-        }
-
         metaClass.validate = {->
             validateMethod.invoke(delegate, "validate", [] as Object[])
         }

test/groovy/org/codehaus/groovy/grails/orm/hibernate/DoNotPersistInvalidObjectTests.groovy

@@ -0,0 +1,63 @@
+package org.codehaus.groovy.grails.orm.hibernate
+/**
+ * @author Graeme Rocher
+ * @since 1.1
+ */
+
+public class DoNotPersistInvalidObjectTests extends AbstractGrailsHibernateTests{
+
+    protected void onSetUp() {
+        gcl.parseClass('''
+import grails.persistence.*
+
+@Entity
+class DoNotPersist {
+    String name
+
+    static constraints = {
+        name size:1..5
+    }
+}
+''')
+    }
+
+
+    void testDoNoPersistInvalidInstanceUsingDirtyChecking() {
+        def testDomain = ga.getDomainClass("DoNotPersist").clazz
+
+        def t = testDomain.newInstance(name:"bob")
+
+        assertNotNull "should have saved test instance",t.save(flush:true)
+
+        session.clear()
+
+        t = testDomain.get(1)
+        t.name = "fartooolong"
+
+        session.flush()
+        session.clear()
+
+        t = testDomain.get(1)
+        assertEquals "bob", t.name
+    }
+
+    void testPersistValidInstanceUsingDirtyChecking() {
+        def testDomain = ga.getDomainClass("DoNotPersist").clazz
+
+        def t = testDomain.newInstance(name:"bob")
+
+        assertNotNull "should have saved test instance",t.save(flush:true)
+
+        session.clear()
+
+        t = testDomain.get(1)
+        t.name = "fred"
+
+        session.flush()
+        session.clear()
+
+        t = testDomain.get(1)
+        assertEquals "fred", t.name
+    }
+
+}