Skip to content

Commit 723dc65

Browse files
GRAILS-11420 - deprecate the spring data binder
1 parent 8b732d1 commit 723dc65

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

grails-plugin-databinding/src/main/groovy/org/codehaus/groovy/grails/plugins/databinding/DataBindingGrailsPlugin.groovy

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,16 @@ package org.codehaus.groovy.grails.plugins.databinding
1717

1818
import grails.util.GrailsUtil
1919

20+
import org.apache.commons.logging.LogFactory
2021
import org.codehaus.groovy.grails.web.binding.BindEventListenerAdapter
21-
import org.codehaus.groovy.grails.web.binding.DataBindingUtils
22-
import org.codehaus.groovy.grails.web.binding.GrailsWebDataBinder
2322
import org.codehaus.groovy.grails.web.binding.bindingsource.DataBindingSourceRegistry
2423
import org.codehaus.groovy.grails.web.binding.bindingsource.DefaultDataBindingSourceRegistry
2524
import org.codehaus.groovy.grails.web.binding.bindingsource.HalJsonDataBindingSourceCreator
2625
import org.codehaus.groovy.grails.web.binding.bindingsource.HalXmlDataBindingSourceCreator
2726
import org.codehaus.groovy.grails.web.binding.bindingsource.JsonDataBindingSourceCreator
2827
import org.codehaus.groovy.grails.web.binding.bindingsource.XmlDataBindingSourceCreator
28+
import org.codehaus.groovy.grails.web.binding.DataBindingUtils
29+
import org.codehaus.groovy.grails.web.binding.GrailsWebDataBinder
2930
import org.grails.databinding.converters.DateConversionHelper
3031
import org.grails.databinding.converters.TimeZoneConverter
3132
import org.grails.databinding.converters.web.LocaleAwareBigDecimalConverter
@@ -44,6 +45,12 @@ class DataBindingGrailsPlugin {
4445

4546
databindingConfig = application?.config?.grails?.databinding
4647

48+
if(Boolean.TRUE.equals(databindingConfig?.useSpringBinder)) {
49+
def msg = 'The grails.databinding.useSpringBinder config property is set to true. The Spring data binder has been deprecated and will be removed in a future release of Grails.'
50+
def log = LogFactory.getLog(DataBindingGrailsPlugin)
51+
log.warn msg
52+
}
53+
4754
def autoGrowCollectionLimitSetting = databindingConfig?.autoGrowCollectionLimit
4855

4956
"${DataBindingUtils.DATA_BINDER_BEAN_NAME}"(GrailsWebDataBinder, ref('grailsApplication')) {

grails-web-databinding-spring/src/main/groovy/org/codehaus/groovy/grails/web/binding/GrailsDataBinder.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,10 @@
9999
* This would set the property "myDate" of type java.util.Date with the specified values.
100100
*
101101
* @author Graeme Rocher
102+
* @deprecated
102103
*/
103104
@SuppressWarnings("rawtypes")
105+
@Deprecated
104106
public class GrailsDataBinder extends ServletRequestDataBinder implements SpringWebDataBinder {
105107

106108
private static final String BIND_EVENT_LISTENERS = "org.codehaus.groovy.grails.BIND_EVENT_LISTENERS";

0 commit comments

Comments
 (0)