Skip to content

Commit 7701c80

Browse files
authored
Merge pull request #14942 from apache/match-profile-forge
Update base, web and rest-api profiles to more closely match Forge
2 parents 48ce16e + fcd23b9 commit 7701c80

File tree

8 files changed

+36
-32
lines changed

8 files changed

+36
-32
lines changed

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/Gradle.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ public void apply(GeneratorContext generatorContext) {
7070

7171
generatorContext.addBuildPlugin(GradlePlugin.builder().id("eclipse").build());
7272
generatorContext.addBuildPlugin(GradlePlugin.builder().id("idea").build());
73-
generatorContext.addBuildPlugin(GradlePlugin.builder().id("groovy").build());
7473

7574
BuildTool buildTool = BuildTool.DEFAULT_OPTION;
7675
GradleBuild build = dependencyResolver.create(generatorContext);

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/grails/GrailsBase.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,10 @@ public void apply(GeneratorContext generatorContext) {
8282
.groupId("org.apache.grails")
8383
.artifactId("grails-logging")
8484
.implementation());
85+
generatorContext.addDependency(Dependency.builder()
86+
.groupId("org.apache.grails")
87+
.artifactId("grails-events")
88+
.implementation());
8589

8690
final ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
8791
generatorContext.addTemplate("src/main/groovy", new URLTemplate("src/main/groovy/.gitkeep", classLoader.getResource(".gitkeep")));

grails-profiles/base/features/less-asset-pipeline/feature.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
description: Adds LESS Transpiler Asset Pipeline to a Grails project
22
build:
33
plugins:
4-
- asset-pipeline
4+
- cloud.wondrify.asset-pipeline
55
dependencies:
66
- scope: build
77
coords: "cloud.wondrify:asset-pipeline-gradle"

grails-profiles/base/profile.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,12 @@ skeleton:
1717
executable: ["**/gradlew*", "**/grailsw*"]
1818
binaryExtensions: ['png','gif','jpg','jpeg','ico','icns','pdf','zip','jar','class']
1919
repositories:
20-
- "https://repository.apache.org/content/groups/public"
2120
- "https://repo.grails.org/grails/restricted"
21+
features:
22+
defaults:
23+
- events
2224
build:
2325
repositories:
24-
- "https://repository.apache.org/content/groups/public"
2526
- "https://repo.grails.org/grails/restricted"
2627
plugins:
2728
- eclipse
@@ -30,12 +31,6 @@ build:
3031
dependencies:
3132
- scope: build
3233
coords: "org.apache.grails:grails-gradle-plugins"
33-
- scope: testAndDevelopmentOnly
34-
coords: "org.webjars.npm:bootstrap"
35-
- scope: testAndDevelopmentOnly
36-
coords: "org.webjars.npm:bootstrap-icons"
37-
- scope: testAndDevelopmentOnly
38-
coords: "org.webjars.npm:jquery"
3934
- scope: implementation
4035
coords: "org.springframework.boot:spring-boot-starter-logging"
4136
- scope: implementation
@@ -46,7 +41,13 @@ dependencies:
4641
coords: "org.springframework.boot:spring-boot-starter"
4742
- scope: implementation
4843
coords: "org.apache.grails:grails-core"
44+
- scope: implementation
45+
coords: "org.apache.grails:grails-i18n"
4946
- scope: testImplementation
5047
coords: "org.apache.grails:grails-testing-support-datamapping"
5148
- scope: console
5249
coords: "org.apache.grails:grails-console"
50+
- scope: runtimeOnly
51+
coords: "org.fusesource.jansi:jansi"
52+
- scope: testImplementation
53+
coords: "org.spockframework:spock-core"

grails-profiles/base/skeleton/build.gradle

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@ buildscript {
22
repositories {
33
mavenCentral()
44
@buildRepositories@
5-
5+
maven {
6+
url = 'https://repository.apache.org/content/groups/snapshots'
7+
content {
8+
includeVersionByRegex('org[.]apache[.](grails|groovy).*', '.*', '.*-SNAPSHOT')
9+
}
10+
}
611
}
712
dependencies {
813
classpath platform("org.apache.grails:grails-bom:$grailsVersion")
@@ -18,11 +23,17 @@ group "@grails.app.group@"
1823
repositories {
1924
mavenCentral()
2025
@repositories@
26+
maven {
27+
url = 'https://repository.apache.org/content/groups/snapshots'
28+
content {
29+
includeVersionByRegex('org[.]apache[.](grails|groovy).*', '.*', '.*-SNAPSHOT')
30+
}
31+
}
2132
}
2233

2334
dependencies {
2435
implementation platform("org.apache.grails:grails-bom:$grailsVersion")
25-
developmentOnly("org.springframework.boot:spring-boot-devtools") // Spring Boot DevTools may cause performance slowdowns or compatibility issues on larger applications
36+
developmentOnly "org.springframework.boot:spring-boot-devtools" // Spring Boot DevTools may cause performance slowdowns or compatibility issues on larger applications
2637
integrationTestImplementation testFixtures("org.apache.grails:grails-geb")
2738
@dependencies@
2839
}

grails-profiles/plugin/features/asset-pipeline-plugin/feature.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
description: Adds Asset Pipeline to a Grails Plugin for packaging
22
build:
33
plugins:
4-
- asset-pipeline
4+
- cloud.wondrify.asset-pipeline
55
dependencies:
66
- scope: build
77
coords: 'cloud.wondrify:asset-pipeline-gradle'

grails-profiles/rest-api/profile.yml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ description: Profile for REST API applications
1616
features:
1717
defaults:
1818
- hibernate5
19-
- events
2019
required:
2120
- json-views
2221
build:
@@ -34,31 +33,17 @@ dependencies:
3433
coords: "org.apache.grails:grails-url-mappings"
3534
- scope: implementation
3635
coords: "org.apache.grails:grails-rest-transforms"
37-
- scope: implementation
38-
coords: "org.apache.grails:grails-codecs"
3936
- scope: implementation
4037
coords: "org.apache.grails:grails-interceptors"
4138
- scope: implementation
4239
coords: "org.apache.grails:grails-services"
43-
- scope: implementation
44-
coords: "org.apache.grails:grails-datasource"
4540
- scope: implementation
4641
coords: "org.apache.grails:grails-databinding"
4742
- scope: implementation
4843
coords: "org.apache.grails:grails-web-boot"
4944
- scope: implementation
5045
coords: "org.apache.grails:grails-logging"
51-
- scope: implementation
52-
coords: "org.apache.grails:grails-cache"
53-
- scope: implementation
54-
coords: "org.apache.grails:grails-async"
55-
- scope: testImplementation
56-
coords: "io.micronaut:micronaut-http-client:4.6.5"
57-
- scope: testImplementation
58-
coords: "org.apache.grails:grails-testing-support-web"
5946
- scope: testImplementation
6047
coords: "org.apache.grails:grails-testing-support-datamapping"
6148
- scope: testImplementation
6249
coords: "org.apache.grails:grails-testing-support-views-gson"
63-
- scope: testImplementation
64-
coords: "org.hibernate.validator:hibernate-validator"

grails-profiles/web/profile.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,21 @@ dependencies:
3939
coords: "org.apache.grails:grails-rest-transforms"
4040
- scope: implementation
4141
coords: "org.apache.grails:grails-databinding"
42-
- scope: implementation
43-
coords: "org.apache.grails:grails-i18n"
4442
- scope: implementation
4543
coords: "org.apache.grails:grails-services"
4644
- scope: implementation
4745
coords: "org.apache.grails:grails-url-mappings"
46+
- scope: implementation
47+
coords: "org.apache.grails:grails-layout"
4848
- scope: implementation
4949
coords: "org.apache.grails:grails-interceptors"
5050
- scope: implementation
5151
coords: "org.apache.grails:grails-scaffolding"
5252
- scope: testImplementation
5353
coords: "org.apache.grails:grails-testing-support-web"
54-
- scope: testImplementation
55-
coords: "org.spockframework:spock-core"
54+
- scope: testAndDevelopmentOnly
55+
coords: "org.webjars.npm:bootstrap"
56+
- scope: testAndDevelopmentOnly
57+
coords: "org.webjars.npm:bootstrap-icons"
58+
- scope: testAndDevelopmentOnly
59+
coords: "org.webjars.npm:jquery"

0 commit comments

Comments
 (0)