Simplify configuration of GSP. Fixes #9936

GroovyPagesGrailsPlugin was reading all plugin gsp/views.properties. This is unnecessary as these files were already read in the BinaryGrailsPlugin class and looked up via GroovyPageLocator from the binary plugins. This changes removes that logic and also adds a change to use classpath:gsp/views.properties which fixes the resolution of the default views.properties for unexploded deployment and for Jetty. See #9936

Author: graemerocher

grails-plugin-gsp/src/main/groovy/org/grails/plugins/web/GroovyPagesGrailsPlugin.groovy

@@ -175,36 +175,18 @@ class GroovyPagesGrailsPlugin extends Plugin {
             }
             if (deployed) {
                 Resource defaultViews = applicationContext?.getResource('gsp/views.properties')
-                List<Resource> allViewsProperties = []
 
-                for(plugin in pluginManager?.allPlugins) {
-
-                    def pluginViews = IOUtils.findResourceRelativeToClass(plugin.getPluginClass(), '/gsp/views.properties')
-                    if(pluginViews != null) {
-                        def res = new UrlResource(pluginViews)
-                        if(res.exists()) {
-                            allViewsProperties.add(res)
-                        }
-                    }
-                }
                 if(defaultViews != null) {
-                    allViewsProperties.add(defaultViews)
+                    if(!defaultViews.exists()) {
+                        defaultViews = applicationContext?.getResource('classpath:gsp/views.properties')
+                    }
                 }
 
-                allViewsProperties = allViewsProperties?.findAll { Resource r ->
-                    def p = r.URL.path
-                    if(warDeployed && p.contains('/WEB-INF/classes')) {
-                        return true
+                if(defaultViews.exists()) {
+                    precompiledGspMap = { PropertiesFactoryBean pfb ->
+                        ignoreResourceNotFound = true
+                        locations = [defaultViews] as Resource[]
                     }
-                    else if(!warDeployed && !p.contains("!/lib")) {
-                        return true
-                    }
-
-                    return false
-                }
-                precompiledGspMap = { PropertiesFactoryBean pfb ->
-                    ignoreResourceNotFound = true
-                    locations = allViewsProperties ? allViewsProperties as Resource[] : 'classpath:gsp/views.properties'
                 }
             }
             if (enableReload) {