Deprecate support for Reactor 2 promises. Fixes #10247

Since Reactor 2 is largely abandoned and Reactor 3 is a complete re-write, it has been decided that Reactor will be completely pulled from the codebase in the future and the Events framework re-written on-top of either RxJava or the regular Spring event publisher. Given this stance it makes sense to deprecate all related Reactor classes now so that users can consider this migration for the future.

Author: graemerocher

grails-async/src/main/groovy/grails/async/Promises.groovy

@@ -13,20 +13,14 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package grails.async;
+package grails.async
 
+import grails.async.decorator.PromiseDecorator
+import groovy.transform.CompileStatic
+import org.grails.async.factory.SynchronousPromiseFactory
+import org.grails.async.factory.gpars.GparsPromiseFactory
 
-import groovy.lang.Closure
-import groovy.transform.CompileStatic;
-
-import java.util.List;
-import java.util.Map;
-import java.util.concurrent.TimeUnit;
-
-import grails.async.decorator.PromiseDecorator;
-import org.grails.async.factory.SynchronousPromiseFactory;
-import org.grails.async.factory.gpars.GparsPromiseFactory;
-import org.grails.async.factory.reactor.ReactorPromiseFactory;
+import java.util.concurrent.TimeUnit
 
 /**
  * Factory class for working with {@link Promise} instances

grails-async/src/main/groovy/org/grails/async/factory/reactor/ReactorPromise.groovy

@@ -31,8 +31,11 @@ import java.util.concurrent.TimeoutException
  *
  * @author Graeme Rocher
  * @since 3.0
+ *
+ * @deprecated Reactor promise integration is deprecated and will be removed in a future version of Grails
  */
 @CompileStatic
+@Deprecated
 class ReactorPromise<T> implements Promise<T> {
 
     reactor.rx.Promise<T> internalPromise

grails-async/src/main/groovy/org/grails/async/factory/reactor/ReactorPromiseFactory.groovy

@@ -31,8 +31,11 @@ import java.util.concurrent.TimeUnit
  *
  * @author Graeme Rocher
  * @since 3.0
+ *
+ * @deprecated Reactor promise integration is deprecated and will be removed in a future version of Grails
  */
 @CompileStatic
+@Deprecated
 class ReactorPromiseFactory extends AbstractPromiseFactory {
     static final boolean REACTOR_PRESENT
     static {

grails-plugin-async/src/main/groovy/org/grails/plugins/web/async/ControllersAsyncGrailsPlugin.groovy

@@ -35,17 +35,11 @@ class ControllersAsyncGrailsPlugin extends Plugin {
 
     Closure doWithSpring() {{->
         asyncPromiseResponseActionResultTransformer(AsyncActionResultTransformer)
-
     }}
 
     @Override
     @CompileStatic
     void doWithDynamicMethods() {
-        try {
-            Promises.promiseFactory = new ReactorPromiseFactory(applicationContext.getBean(Environment))
-        } catch (NoSuchBeanDefinitionException e) {
-            // Reactor not configured
-        }
         Promises.promiseFactory.addPromiseDecoratorLookupStrategy(new WebRequestPromiseDecoratorLookupStrategy())
     }