Improving configureGebBaseUrl

This should generate a method like this:

    @Autowired
    public void configureGebBaseUrl(@value("${server.contextPath:/}")
String serverContextPath, @value("${local.server.port}") int
serverPort) {
        String $baseUrl =
"http://localhost:${serverPort}${serverContextPath}".toString()
        if(!$baseUrl.endsWith("/")) {
            $baseUrl += "/"
        }

        System.setProperty("geb.build.baseUrl", $baseUrl)
    }

Working on #10306

Author: jeffscottbrown

grails-plugin-testing/src/main/groovy/org/grails/compiler/injection/test/IntegrationTestMixinTransformation.groovy

@@ -5,10 +5,11 @@ import grails.test.mixin.integration.Integration
 import groovy.transform.CompileStatic
 import org.codehaus.groovy.ast.*
 import org.codehaus.groovy.ast.expr.*
-import org.codehaus.groovy.ast.stmt.BlockStatement
-import org.codehaus.groovy.ast.stmt.ExpressionStatement
+import org.codehaus.groovy.ast.stmt.*
 import org.codehaus.groovy.control.CompilePhase
 import org.codehaus.groovy.control.SourceUnit
+import org.codehaus.groovy.syntax.Token
+import org.codehaus.groovy.syntax.Types
 import org.codehaus.groovy.transform.ASTTransformation
 import org.codehaus.groovy.transform.GroovyASTTransformation
 import org.grails.compiler.injection.GrailsASTUtils
@@ -179,13 +180,24 @@ class IntegrationTestMixinTransformation implements ASTTransformation {
             spValueAnnotation.setMember('value', new ConstantExpression('${local.server.port}'))
             serverPortParameter.addAnnotation(spValueAnnotation)
 
-            def setterBody = new BlockStatement()
+            Expression urlExpression = new GStringExpression('http://localhost:${serverPort}${serverContextPath}', [new ConstantExpression('http://localhost:'), new ConstantExpression(""), new ConstantExpression("")], [new VariableExpression('serverPort'), new VariableExpression('serverContextPath')] as List<Expression>)
+
+            Expression baseUrlVariableExpression = new VariableExpression('$baseUrl', ClassHelper.make(String))
+            Expression declareBaseUrlExpression = new DeclarationExpression(baseUrlVariableExpression, Token.newSymbol(Types.EQUALS, 0, 0), new MethodCallExpression(urlExpression, 'toString', new ArgumentListExpression()))
+
+            Expression constantSlashExpression = new ConstantExpression('/')
+            Expression endsWithMethodCall = new MethodCallExpression(baseUrlVariableExpression, 'endsWith', new ArgumentListExpression(constantSlashExpression))
+            Expression appendSlashExpression = new BinaryExpression(baseUrlVariableExpression, Token.newSymbol(Types.PLUS_EQUAL, 0, 0), constantSlashExpression)
+            Statement ifUrlEndsWithSlashStatement = new IfStatement(new BooleanExpression(endsWithMethodCall), new EmptyStatement(), new ExpressionStatement(appendSlashExpression))
+            def methodBody = new BlockStatement()
+            methodBody.addStatement(new ExpressionStatement(declareBaseUrlExpression))
+            methodBody.addStatement(ifUrlEndsWithSlashStatement)
             def systemClassExpression = new ClassExpression(ClassHelper.make(System))
             def args = new ArgumentListExpression()
             args.addExpression(new ConstantExpression("geb.build.baseUrl"))
-            args.addExpression(new GStringExpression('http://localhost:${serverPort}${serverContextPath}', [new ConstantExpression('http://localhost:'), new ConstantExpression(""), new ConstantExpression("")], [new VariableExpression('serverPort'), new VariableExpression('serverContextPath')] as List<Expression>))
-            setterBody.addStatement(new ExpressionStatement(new MethodCallExpression(systemClassExpression, "setProperty", args)))
-            def method = new MethodNode("configureGebBaseUrl", Modifier.PUBLIC, ClassHelper.VOID_TYPE, [contextPathParameter, serverPortParameter] as Parameter[], null, setterBody)
+            args.addExpression(baseUrlVariableExpression)
+            methodBody.addStatement(new ExpressionStatement(new MethodCallExpression(systemClassExpression, "setProperty", args)))
+            def method = new MethodNode("configureGebBaseUrl", Modifier.PUBLIC, ClassHelper.VOID_TYPE, [contextPathParameter, serverPortParameter] as Parameter[], null, methodBody)
             method.addAnnotation(new AnnotationNode(ClassHelper.make(Autowired)))
             classNode.addMethod(method)
         }