GRAILS-10871 - improve non domain class validation

The validator should ignore properties which already have binding errors associated with them.

Author: jeffscottbrown

grails-plugin-validation/src/main/groovy/org/codehaus/groovy/grails/web/plugins/support/ValidationSupport.groovy

@@ -56,8 +56,11 @@ class ValidationSupport {
             }
             for (prop in constraints.values()) {
                 if (fieldsToValidate == null || fieldsToValidate.contains(prop.propertyName)) {
-                    prop.messageSource = messageSource
-                    prop.validate(object, object.getProperty(prop.propertyName), localErrors)
+                    def fieldError = originalErrors.getFieldError(prop.propertyName)
+                    if(fieldError == null || !fieldError.bindingFailure) {
+                        prop.messageSource = messageSource
+                        prop.validate(object, object.getProperty(prop.propertyName), localErrors)
+                    }
                 }
             }
             object.errors = localErrors

grails-test-suite-uber/src/test/groovy/grails/validation/ValidateableSpec.groovy

@@ -2,6 +2,10 @@ package grails.validation
 
 import grails.test.mixin.TestMixin
 import grails.test.mixin.support.GrailsUnitTestMixin
+
+import org.springframework.validation.FieldError
+
+import spock.lang.Issue
 import spock.lang.Specification
 
 @TestMixin(GrailsUnitTestMixin)
@@ -77,6 +81,31 @@ class ValidateableSpec extends Specification {
         !validateable.hasErrors()
         validateable.errors.errorCount == 0
     }
+    
+    @Issue('GRAILS-10871')
+    void 'Test that binding failures are retained during validation and that the corresponding property is not validated'() {
+        given:
+        def validateable = new MyValidateable()
+        
+        when:
+        def fieldError = new FieldError(MyValidateable.name, 'age', 'forty two', true, null, null, null)
+        validateable.errors.addError fieldError
+       
+        then:
+        validateable.hasErrors()
+        validateable.errors.errorCount == 1
+        validateable.errors.getFieldError('age').rejectedValue == 'forty two'
+        
+        when:
+        validateable.name = 'lower case'
+        
+        then:
+        !validateable.validate()
+        validateable.hasErrors()
+        validateable.errors.errorCount == 2
+        validateable.errors.getFieldError('age').rejectedValue == 'forty two'
+        validateable.errors.getFieldError('name').rejectedValue == 'lower case'
+    }
 }
 
 @Validateable