Ensure plugin artefacts are registered in reverse order due to them always being added as the first item in the list. Also ensure plugin artefacts are registered before application artefacts, thus allowing overriding. Fixes #9706

Author: graemerocher

grails-core/src/main/groovy/grails/boot/config/GrailsApplicationPostProcessor.groovy

@@ -102,10 +102,12 @@ class GrailsApplicationPostProcessor implements BeanDefinitionRegistryPostProces
     protected void performGrailsInitializationSequence() {
         pluginManager.doArtefactConfiguration()
         grailsApplication.initialise()
+        // register plugin provided classes first, this gives the oppurtunity
+        // for application classes to override those provided by a plugin
+        pluginManager.registerProvidedArtefacts(grailsApplication)
         for(cls in classes) {
             grailsApplication.addArtefact(cls)
         }
-        pluginManager.registerProvidedArtefacts(grailsApplication)
     }
 
     protected void loadApplicationConfig() {

grails-core/src/main/groovy/org/grails/plugins/AbstractGrailsPluginManager.java

@@ -301,7 +301,12 @@ public void setApplication(GrailsApplication application) {
     public void registerProvidedArtefacts(GrailsApplication app) {
         checkInitialised();
 
-        for (GrailsPlugin plugin : pluginList) {
+        // since plugin classes are added as overridable artefacts, which are added as the first
+        // item in the list of artefacts, we have to iterate in reverse order to ensure plugin
+        // load sequence is maintained
+        ArrayList<GrailsPlugin> plugins = new ArrayList<GrailsPlugin>(pluginList);
+        Collections.reverse(plugins);
+        for (GrailsPlugin plugin : plugins) {
             if (plugin.supportsCurrentScopeAndEnvironment()) {
                 if(isPluginDisabledForProfile(plugin)) continue;
                 for (Class<?> artefact : plugin.getProvidedArtefacts()) {

grails-web-url-mappings/src/main/groovy/org/grails/web/mapping/UrlMappingsHolderFactoryBean.java

@@ -79,16 +79,14 @@ public void afterPropertiesSet() throws Exception {
         List excludePatterns = new ArrayList();
 
         GrailsClass[] mappings = grailsApplication.getArtefacts(UrlMappingsArtefactHandler.TYPE);
-        List<GrailsClass> mappingList = Arrays.asList(mappings);
-        Collections.reverse(mappingList);
         final DefaultUrlMappingEvaluator mappingEvaluator = new DefaultUrlMappingEvaluator(applicationContext);
         mappingEvaluator.setPluginManager(pluginManager);
 
         if (mappings.length == 0) {
             urlMappings.addAll(mappingEvaluator.evaluateMappings(DefaultUrlMappings.getMappings()));
         }
         else {
-            for (GrailsClass mapping : mappingList) {
+            for (GrailsClass mapping : mappings) {
                 GrailsUrlMappingsClass mappingClass = (GrailsUrlMappingsClass) mapping;
                 List grailsClassMappings;
                 if (Script.class.isAssignableFrom(mappingClass.getClazz())) {