Whitespace issues and lack of tests for actionSubmit and actionSubmitImage - GRAILS-680

git-svn-id: https://svn.codehaus.org/grails/trunk@2959 1cfb16fd-6d17-0410-8ff1-b7e8e1e2867d

Author: marcpalmer

src/grails/grails-app/taglib/FormTagLib.groovy

@@ -150,13 +150,13 @@ class FormTagLib {
         out << '<input type="submit" name="_action" '
         def value = attrs.remove('value')
         if(value) {
-             out << "value=\"${value}\""
+             out << "value=\"${value}\" "
         }
         // process remaining attributes
         outputAttributes(attrs)
 
         // close tag
-        out.println '/>'
+        out << '/>'
 
     }
     /**
@@ -171,17 +171,17 @@ class FormTagLib {
         out << '<input type="image" name="_action" '
         def value = attrs.remove('value')
         if(value) {
-             out << "value=\"${value}\""
+             out << "value=\"${value}\" "
         }
         def src = attrs.remove('src')
         if(src) {
-             out << "src=\"${src}\""
+             out << "src=\"${src}\" "
         }
         // process remaining attributes
         outputAttributes(attrs)
 
         // close tag
-        out.println '/>'
+        out << '/>'
 
     }
 

test/groovy/org/codehaus/groovy/grails/web/taglib/FormTagLibTests.groovy

@@ -46,11 +46,35 @@ public class FormTagLibTests extends AbstractGrailsTagTests {
     	    // use sorted map to be able to predict the order in which tag attributes are generated
 	    	def attributes = new TreeMap([url:[controller:'con', action:'action'], id:'formElementId'])
     	    tag.call(attributes, { })
-    	    println sw.toString()
     	    assertEquals '<form action="/con/action" method="post" id="formElementId" ></form>', sw.toString().trim()
     	}
     }
 
+    void testActionSubmitWhitespace() {
+    	final StringWriter sw = new StringWriter();
+    	final PrintWriter pw = new PrintWriter(sw);
+
+    	withTag("actionSubmit", pw) { tag ->
+    	    // use sorted map to be able to predict the order in which tag attributes are generated
+	    	def attributes = new TreeMap([value:'Go'])
+    	    tag.call(attributes)
+    	    println sw.toString()
+    	    assertEquals '<input type="submit" name="_action" value="Go" />', sw.toString() // NO TRIM, TEST WS!
+    	}
+    }
+
+    void testActionSubmitImageWhitespace() {
+    	final StringWriter sw = new StringWriter();
+    	final PrintWriter pw = new PrintWriter(sw);
+
+    	withTag("actionSubmitImage", pw) { tag ->
+    	    // use sorted map to be able to predict the order in which tag attributes are generated
+	    	def attributes = new TreeMap([src:'button.gif', value:'Go'])
+    	    tag.call(attributes)
+    	    assertEquals '<input type="image" name="_action" value="Go" src="button.gif" />', sw.toString() // NO TRIM, TEST WS!
+    	}
+    }
+
     public void testHtmlEscapingTextAreaTag() {
     	final StringWriter sw = new StringWriter();
     	final PrintWriter pw = new PrintWriter(sw);