fix behaviour of constraints applied to derived properties

graemerocher · graemerocher · commit 936cd8d11b5f · 2016-12-19T16:24:40.000+01:00
diff --git a/grails-validation/src/main/groovy/org/grails/validation/DefaultConstraintEvaluator.java b/grails-validation/src/main/groovy/org/grails/validation/DefaultConstraintEvaluator.java
@@ -170,8 +170,9 @@ protected Map<String, Constrained> evaluateConstraints(Map<String, Constrained>
                         // remove the constraint given by user and warn
                         if (constraintMap.remove(propertyName) != null) {
                             LOG.warn("Derived domainClassProperties may not be constrained. Property [" + propertyName + "] of domain class " + theClass.getName() + " will not be checked during validation.");
-                            continue;
                         }
+                        // always remove constraints on derived properties
+                        continue;
                     }
                 }
                 else {

Original file line number	Diff line number	Diff line change
`@@ -170,8 +170,9 @@ protected Map<String, Constrained> evaluateConstraints(Map<String, Constrained>`
`170`	`170`	`// remove the constraint given by user and warn`
`171`	`171`	`if (constraintMap.remove(propertyName) != null) {`
`172`	`172`	`LOG.warn("Derived domainClassProperties may not be constrained. Property [" + propertyName + "] of domain class " + theClass.getName() + " will not be checked during validation.");`
`173`		`- continue;`
`174`	`173`	`}`
	`174`	`+ // always remove constraints on derived properties`
	`175`	`+ continue;`
`175`	`176`	`}`
`176`	`177`	`}`
`177`	`178`	`else {`