Wrap filename with quotes when setting content disposition header

jameskleeh · jameskleeh · commit c75046109a5a · 2016-12-09T17:03:24.000-05:00
diff --git a/grails-plugin-controllers/src/main/groovy/grails/artefact/controller/support/ResponseRenderer.groovy b/grails-plugin-controllers/src/main/groovy/grails/artefact/controller/support/ResponseRenderer.groovy
@@ -393,7 +393,7 @@ trait ResponseRenderer extends WebAttributes {
                         hasContentType = detectContentTypeFromFileName(webRequest, response, argMap, fileName)
                     }
                     if (fnO) {
-                        response.setHeader HttpHeaders.CONTENT_DISPOSITION, DISPOSITION_HEADER_PREFIX + fileName
+                        response.setHeader HttpHeaders.CONTENT_DISPOSITION, "$DISPOSITION_HEADER_PREFIX\"$fileName\""
                     }
                 }
                 if (!hasContentType) {

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ trait ResponseRenderer extends WebAttributes {`
`393`	`393`	`hasContentType = detectContentTypeFromFileName(webRequest, response, argMap, fileName)`
`394`	`394`	`}`
`395`	`395`	`if (fnO) {`
`396`		`- response.setHeader HttpHeaders.CONTENT_DISPOSITION, DISPOSITION_HEADER_PREFIX + fileName`
	`396`	`+ response.setHeader HttpHeaders.CONTENT_DISPOSITION, "$DISPOSITION_HEADER_PREFIX\"$fileName\""`
`397`	`397`	`}`
`398`	`398`	`}`
`399`	`399`	`if (!hasContentType) {`