Skip to content

Commit c826b52

Browse files
committed
Revert "Remove unnecessary test dependencies from build (#12390)"
This reverts commit ca01dbe
1 parent dab9c07 commit c826b52

File tree

12 files changed

+9
-17
lines changed

12 files changed

+9
-17
lines changed

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,11 +428,11 @@ subprojects { project ->
428428
sourceCompatibility = "1.8"
429429
targetCompatibility = "1.8"
430430

431-
if(project.name =~ /^(grails-web|grails-plugin-|grails-test-suite)/) {
431+
if(project.name =~ /^(grails-web|grails-plugin-|grails-test-suite|grails-test)/) {
432432
dependencies {
433433
api "javax.servlet:javax.servlet-api:$servletApiVersion"
434434
// MockHttpServletRequest/Response/Context used in many classes
435-
testImplementation("org.springframework:spring-test:${springVersion}") {
435+
api("org.springframework:spring-test:${springVersion}") {
436436
exclude group: 'commons-logging', module:'commons-logging'
437437
}
438438
}

grails-console/src/main/groovy/grails/ui/console/support/GroovyConsoleWebApplicationContext.groovy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ import grails.ui.support.DevelopmentWebApplicationContext
66
import grails.util.BuildSettings
77
import groovy.transform.CompileStatic
88
import groovy.transform.InheritConstructors
9+
import org.springframework.mock.web.MockServletConfig
10+
import org.springframework.mock.web.MockServletContext
911
import org.springframework.web.context.support.GenericWebApplicationContext
1012

1113
/*

grails-core/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ dependencies {
3636
exclude group: 'commons-logging', module:'commons-logging'
3737
}
3838

39-
testImplementation("org.springframework:spring-test:${springVersion}") {
39+
compileOnly("org.springframework:spring-test:${springVersion}") {
4040
exclude group: 'commons-logging', module:'commons-logging'
4141
}
4242
compileOnly("org.codehaus.groovy:groovy-templates:$groovyVersion")

grails-plugin-controllers/build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ dependencies {
88
api("org.springframework.boot:spring-boot-autoconfigure:$springBootVersion")
99
runtimeOnly project(':grails-plugin-i18n')
1010

11-
testImplementation project(":grails-test")
12-
1311
testRuntimeOnly "jline:jline:$jlineVersion"
1412
testRuntimeOnly "org.fusesource.jansi:jansi:$jansiVersion"
1513
}

grails-plugin-i18n/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
dependencies {
22
api project(":grails-web")
3+
4+
api "org.codehaus.groovy:groovy-ant:$groovyVersion"
35
}
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
dependencies {
22
api project(":grails-plugin-controllers")
33
api project(":grails-plugin-url-mappings")
4-
5-
testImplementation project(":grails-test")
64
}

grails-plugin-mimetypes/build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,4 @@ dependencies {
1010
compileOnly "io.micronaut:micronaut-runtime:$micronautVersion"
1111

1212
api project(":grails-web")
13-
14-
testImplementation project(":grails-test")
1513
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
dependencies {
22
api project(":grails-web"), project(":grails-plugin-controllers")
3+
api "junit:junit:${junitVersion}"
34
}

grails-test/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ dependencies {
1111

1212

1313
api project(":grails-plugin-mimetypes")
14+
api project(":grails-web")
1415
api "org.grails.plugins:converters:$legacyConvertersVersion"
1516

1617
// command line requirements
@@ -23,8 +24,4 @@ dependencies {
2324

2425
// needed for Spock
2526
api "org.objenesis:objenesis:${objenesisVersion}"
26-
27-
api("org.springframework:spring-test:${springVersion}") {
28-
exclude group: 'commons-logging', module:'commons-logging'
29-
}
3027
}

grails-web-common/build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,4 @@ dependencies {
1414
api "org.springframework:spring-webmvc:${springVersion}"
1515
api "org.springframework:spring-context-support:${springVersion}"
1616
implementation "com.github.ben-manes.caffeine:caffeine:$caffeineVersion"
17-
18-
testImplementation project(":grails-test")
1917
}

0 commit comments

Comments
 (0)