Skip to content

Commit d001c6c

Browse files
committed
Merge branch '6.1.x' into 6.2.x
Conflicts: .github/workflows/groovy-joint-workflow.yml .github/workflows/release.yml build.gradle gradle.properties grails-bom/plugins.properties grails-core/src/test/groovy/grails/util/GrailsUtilTests.java grails-databinding/src/test/groovy/grails/databinding/SimpleDataBinderSpec.groovy grails-docs/build.gradle grails-shell/src/main/groovy/org/grails/cli/profile/AbstractProfile.groovy grails-test-suite-persistence/build.gradle grails-test-suite-uber/build.gradle grails-test-suite-web/build.gradle settings.gradle
2 parents a9491c0 + e2061a8 commit d001c6c

File tree

83 files changed

+715
-627
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

83 files changed

+715
-627
lines changed

.github/workflows/gradle.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ jobs:
3131
uses: gradle/gradle-build-action@29c0906b64b8fc82467890bfb7a0a7ef34bda89e # v3
3232
env:
3333
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
34-
GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER }}
35-
GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY }}
3634
with:
3735
arguments: build groovydoc
3836
publish:
@@ -55,8 +53,6 @@ jobs:
5553
uses: gradle/gradle-build-action@29c0906b64b8fc82467890bfb7a0a7ef34bda89e # v3
5654
env:
5755
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
58-
GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER }}
59-
GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY }}
6056
ARTIFACTORY_USERNAME: ${{ secrets.ARTIFACTORY_USERNAME }}
6157
ARTIFACTORY_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }}
6258
with:

.github/workflows/groovy-joint-workflow.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,10 @@ jobs:
5252
- name: Checkout Groovy 3_0_X (Grails 5 and later)
5353
if: startsWith(github.ref, 'refs/heads/6.') || startsWith(github.base_ref, '6.') || startsWith(github.ref, 'refs/heads/5.') || startsWith(github.base_ref, '5.')
5454
run: cd .. && git clone --depth 1 https://github.com/apache/groovy.git -b GROOVY_3_0_X --single-branch
55-
- name: Set CI_GROOVY_VERSION for Grails
55+
- name: Get Groovy version for Grails
5656
id: groovy-version
5757
run: |
5858
cd ../groovy
59-
echo "CI_GROOVY_VERSION=$(cat gradle.properties | grep groovyVersion | cut -d\= -f2 | tr -d '[:space:]')" >> $GITHUB_ENV
6059
echo "value=$(cat gradle.properties | grep groovyVersion | cut -d\= -f2 | tr -d '[:space:]')" >> $GITHUB_OUTPUT
6160
- name: Prepare GE Set-up Configuration
6261
id: ge_conf
@@ -130,7 +129,7 @@ jobs:
130129
distribution: 'adopt'
131130
java-version: '11'
132131
- name: Cache local Maven repository & Groovy
133-
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4
132+
uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4
134133
with:
135134
path: |
136135
~/groovy
@@ -143,10 +142,11 @@ jobs:
143142
id: build_grails
144143
uses: gradle/gradle-build-action@29c0906b64b8fc82467890bfb7a0a7ef34bda89e # v3
145144
env:
145+
ORG_GRADLE_PROJECT_groovyVersion: ${{ needs.build_groovy.outputs.groovyVersion }}
146146
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
147147
GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER }}
148148
GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY }}
149149
with:
150150
arguments: |
151151
build
152-
-x groovydoc
152+
-x groovydoc

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY }}
5353
- name: Upload Distribution
5454
if: success()
55-
uses: actions/upload-artifact@v4
55+
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
5656
with:
5757
name: grails-${{ steps.release_version.outputs.value }}.zip
5858
path: build/distributions/grails-${{ steps.release_version.outputs.value }}.zip

.github/workflows/retry-release.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ jobs:
4949
arguments: assemble
5050
env:
5151
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
52-
GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER }}
53-
GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY }}
5452
- name: Upload artifacts to the Github release
5553
id: upload_artifact
5654
if: steps.assemble.outcome == 'success'

build.gradle

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ ext {
3030
// When making changes in the dependencyVersions, remember to also update the Grails BOM Documentation:
3131
// https://docs.grails.org/snapshot/ref/Dependency%20Versions/Grails%20BOM.html
3232
dependencyVersions = [
33-
'fieldsPlugin' : [version: feildsPluginVersion,
33+
'fieldsPlugin' : [version: fieldsPluginVersion,
3434
group : 'org.grails.plugins',
3535
names : ['fields'],
3636
modules: ['']
@@ -223,14 +223,14 @@ if (isReleaseVersion) {
223223

224224
allprojects {
225225
repositories {
226-
mavenLocal()
226+
mavenLocal() // Used by the Groovy Joint Validation Github workflow after building groovy locally in CI
227227
mavenCentral()
228-
maven { url "https://repo.grails.org/grails/core" }
229-
maven { url "https://oss.sonatype.org/content/repositories/snapshots/" }
228+
maven { url = "https://repo.grails.org/grails/core" }
229+
maven { url = "https://oss.sonatype.org/content/repositories/snapshots/" }
230230
if (groovyVersion.endsWith('-SNAPSHOT')) {
231-
maven {
232-
name 'JFrog OSS snapshot repo'
233-
url 'https://oss.jfrog.org/oss-snapshot-local/'
231+
maven { // Used for testing with Groovy snapshots locally
232+
name = 'Groovy Snapshot repository'
233+
url = 'https://groovy.jfrog.io/artifactory/libs-snapshot-local/'
234234
}
235235
}
236236
}

gradle.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ cglibVersion=2.2.2
77
commonsLangVersion=2.6
88
datastoreVersion=8.1.2
99
directoryWatcherVersion=0.9.9
10-
feildsPluginVersion=5.1.0-SNAPSHOT
10+
fieldsPluginVersion=5.1.0-SNAPSHOT
1111
gdocEngineVersion=1.0.1
1212
gradleNexusPluginVersion=2.3.1
1313
gradleNexusStagingPluginVersion=0.12.0
@@ -42,6 +42,7 @@ spockVersion=2.1-groovy-3.0
4242
springBootVersion=2.7.18
4343
springLoadedVersion=1.2.8.RELEASE
4444
springVersion=5.3.39
45+
spring.version=5.3.39
4546
testingSupportVersion=3.2.1
4647
testingSupportVersionForTests=3.2.2
4748
tomcatLog4jVersion=8.5.2

gradle/idea.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import groovy.xml.XmlParser
2+
13
idea {
24
project {
35
jdkName "1.7"

grails-bootstrap/src/main/groovy/grails/codegen/model/ModelBuilder.groovy

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ package grails.codegen.model
1717

1818
import grails.util.GrailsNameUtils
1919
import groovy.transform.CompileStatic
20-
import org.codehaus.groovy.runtime.MetaClassHelper
20+
import org.apache.groovy.util.BeanUtils
2121
import org.grails.io.support.FileSystemResource
2222
import org.grails.io.support.GrailsResourceUtils
2323
import org.grails.io.support.Resource
@@ -89,7 +89,7 @@ trait ModelBuilder {
8989
final String packagePath
9090

9191
ModelImpl(String className) {
92-
this.className = MetaClassHelper.capitalize(GrailsNameUtils.getShortName(className))
92+
this.className = BeanUtils.capitalize(GrailsNameUtils.getShortName(className))
9393
this.fullName = className
9494
this.propertyName = GrailsNameUtils.getPropertyName(className)
9595
this.packageName = GrailsNameUtils.getPackageName(className)
@@ -111,7 +111,14 @@ trait ModelBuilder {
111111

112112
@Override
113113
Map<String, Object> asMap() {
114-
(Map<String,Object>) [ className: className, fullName: fullName, propertyName: propertyName, modelName: propertyName, packageName: packageName, packagePath: packagePath, simpleName: simpleName, lowerCaseName: lowerCaseName]
114+
[className: className,
115+
fullName: fullName,
116+
propertyName: propertyName,
117+
modelName: propertyName,
118+
packageName: packageName,
119+
packagePath: packagePath,
120+
simpleName: simpleName,
121+
lowerCaseName: lowerCaseName] as Map<String, Object>
115122
}
116123
}
117124

grails-bootstrap/src/main/groovy/org/grails/io/support/SpringIOUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package org.grails.io.support;
1717

18-
import groovy.util.XmlSlurper;
18+
import groovy.xml.XmlSlurper;
1919
import groovy.xml.FactorySupport;
2020
import org.xml.sax.SAXException;
2121
import javax.xml.XMLConstants;

grails-console/src/main/groovy/grails/ui/shell/support/GroovyshApplicationContext.groovy

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,10 @@
1616
package grails.ui.shell.support
1717

1818
import grails.core.GrailsApplication
19-
import grails.ui.support.DevelopmentWebApplicationContext
20-
import org.codehaus.groovy.tools.shell.Groovysh
19+
import org.apache.groovy.groovysh.Groovysh
2120
import org.codehaus.groovy.tools.shell.IO
2221
import org.springframework.context.support.GenericApplicationContext
2322

24-
2523
/**
2624
* @author Graeme Rocher
2725
* @since 3.0

0 commit comments

Comments
 (0)