Skip to content

Commit d860ef7

Browse files
authored
Merge pull request #15150 from gustavoharff/patch-1
Apply Generated annotation
2 parents 6ffb914 + 0d95a86 commit d860ef7

File tree

51 files changed

+567
-33
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+567
-33
lines changed

grails-datamapping-async/src/main/groovy/grails/gorm/async/AsyncEntity.groovy

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
package grails.gorm.async
2121

2222
import groovy.transform.CompileStatic
23-
23+
import groovy.transform.Generated
2424
import org.grails.datastore.gorm.GormEnhancer
2525
import org.grails.datastore.gorm.GormEntity
2626
import org.grails.datastore.gorm.async.GormAsyncStaticApi
@@ -37,6 +37,7 @@ trait AsyncEntity<D> extends GormEntity<D> {
3737
/**
3838
* @return The async version of the GORM static API
3939
*/
40+
@Generated
4041
static GormAsyncStaticApi<D> getAsync() {
4142
return new GormAsyncStaticApi(GormEnhancer.findStaticApi(this))
4243
}

grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/schemaless/ImplementsDynamicAttributes.groovy

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,12 @@
1818
*/
1919
package org.grails.datastore.gorm.schemaless
2020

21+
import groovy.transform.Generated
2122
import spock.lang.Issue
2223
import spock.lang.Specification
2324

25+
import java.lang.reflect.Method
26+
2427

2528
class DynamicDomainSpec extends Specification {
2629

@@ -41,6 +44,12 @@ class DynamicDomainSpec extends Specification {
4144
entity.attributes().foo == 123
4245
}
4346

47+
void "test that all DynamicAttributes trait methods are marked as Generated"() {
48+
expect: "all DynamicAttributes methods are marked as Generated on implementation class"
49+
DynamicAttributes.getMethods().each { Method traitMethod ->
50+
assert DynamicEntity.class.getMethod(traitMethod.name, traitMethod.parameterTypes).isAnnotationPresent(Generated)
51+
}
52+
}
4453
}
4554

4655
class DynamicEntity implements DynamicAttributes {
@@ -51,4 +60,4 @@ class DynamicEntity implements DynamicAttributes {
5160
"foo"
5261
}
5362

54-
}
63+
}

grails-datamapping-core/src/main/groovy/grails/gorm/MultiTenant.groovy

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
package grails.gorm
2121

2222
import groovy.transform.CompileStatic
23-
23+
import groovy.transform.Generated
2424
import grails.gorm.api.GormAllOperations
2525
import org.grails.datastore.gorm.GormEnhancer
2626
import org.grails.datastore.mapping.core.connections.ConnectionSource
@@ -41,6 +41,7 @@ trait MultiTenant<D> extends Entity {
4141
* @param callable The closure
4242
* @return The result of the closure
4343
*/
44+
@Generated
4445
static <T> T withTenant(Serializable tenantId, Closure<T> callable) {
4546
GormEnhancer.findStaticApi(this).withTenant(tenantId, callable)
4647
}
@@ -51,6 +52,7 @@ trait MultiTenant<D> extends Entity {
5152
* @param callable The closure
5253
* @return The result of the closure
5354
*/
55+
@Generated
5456
static <D> GormAllOperations eachTenant(Closure callable) {
5557
GormEnhancer.findStaticApi(this, ConnectionSource.DEFAULT).eachTenant(callable)
5658
}
@@ -61,6 +63,7 @@ trait MultiTenant<D> extends Entity {
6163
* @param tenantId The tenant id
6264
* @return The operations
6365
*/
66+
@Generated
6467
static <D> GormAllOperations<D> withTenant(Serializable tenantId) {
6568
(GormAllOperations<D>) GormEnhancer.findStaticApi(this).withTenant(tenantId)
6669
}

grails-datamapping-core/src/main/groovy/grails/gorm/time/InstantConverter.groovy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ package grails.gorm.time
2222
import java.time.Instant
2323

2424
import groovy.transform.CompileStatic
25+
import groovy.transform.Generated
2526

2627
/**
2728
* A trait to convert a {@link java.time.Instant} to and from a long
@@ -31,10 +32,12 @@ import groovy.transform.CompileStatic
3132
@CompileStatic
3233
trait InstantConverter {
3334

35+
@Generated
3436
Long convert(Instant value) {
3537
value.toEpochMilli()
3638
}
3739

40+
@Generated
3841
Instant convert(Long value) {
3942
Instant.ofEpochMilli(value)
4043
}

grails-datamapping-core/src/main/groovy/grails/gorm/time/LocalDateConverter.groovy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import java.time.ZoneId
2727
import java.time.ZoneOffset
2828

2929
import groovy.transform.CompileStatic
30+
import groovy.transform.Generated
3031

3132
/**
3233
* A trait to convert a {@link LocalDate} to and from a long
@@ -37,12 +38,14 @@ import groovy.transform.CompileStatic
3738
trait LocalDateConverter extends TemporalConverter<LocalDate> {
3839

3940
@Override
41+
@Generated
4042
Long convert(LocalDate value) {
4143
LocalDateTime localDateTime = LocalDateTime.of(value, LocalTime.MIN)
4244
localDateTime.toInstant(ZoneOffset.UTC).toEpochMilli()
4345
}
4446

4547
@Override
48+
@Generated
4649
LocalDate convert(Long value) {
4750
Instant instant = Instant.ofEpochMilli(value)
4851
LocalDateTime.ofInstant(instant, ZoneId.of('UTC')).toLocalDate()

grails-datamapping-core/src/main/groovy/grails/gorm/time/LocalDateTimeConverter.groovy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import java.time.ZoneId
2525
import java.time.ZoneOffset
2626

2727
import groovy.transform.CompileStatic
28+
import groovy.transform.Generated
2829

2930
/**
3031
* A trait to convert a {@link java.time.LocalDateTime} to and from a long
@@ -35,11 +36,13 @@ import groovy.transform.CompileStatic
3536
trait LocalDateTimeConverter implements TemporalConverter<LocalDateTime> {
3637

3738
@Override
39+
@Generated
3840
Long convert(LocalDateTime value) {
3941
value.toInstant(ZoneOffset.UTC).toEpochMilli()
4042
}
4143

4244
@Override
45+
@Generated
4346
LocalDateTime convert(Long value) {
4447
LocalDateTime.ofInstant(Instant.ofEpochMilli(value), ZoneId.of('UTC'))
4548
}

grails-datamapping-core/src/main/groovy/grails/gorm/time/LocalTimeConverter.groovy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ package grails.gorm.time
2222
import java.time.LocalTime
2323

2424
import groovy.transform.CompileStatic
25+
import groovy.transform.Generated
2526

2627
/**
2728
* A trait to convert a {@link LocalTime} to and from a long
@@ -32,11 +33,13 @@ import groovy.transform.CompileStatic
3233
trait LocalTimeConverter implements TemporalConverter<LocalTime> {
3334

3435
@Override
36+
@Generated
3537
Long convert(LocalTime value) {
3638
value.toNanoOfDay()
3739
}
3840

3941
@Override
42+
@Generated
4043
LocalTime convert(Long value) {
4144
LocalTime.ofNanoOfDay(value)
4245
}

grails-datamapping-core/src/main/groovy/grails/gorm/time/OffsetDateTimeConverter.groovy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import java.time.Instant
2323
import java.time.OffsetDateTime
2424

2525
import groovy.transform.CompileStatic
26+
import groovy.transform.Generated
2627

2728
/**
2829
* A trait to convert a {@link java.time.OffsetDateTime} to and from a long
@@ -33,11 +34,13 @@ import groovy.transform.CompileStatic
3334
trait OffsetDateTimeConverter implements TemporalConverter<OffsetDateTime> {
3435

3536
@Override
37+
@Generated
3638
Long convert(OffsetDateTime value) {
3739
value.toInstant().toEpochMilli()
3840
}
3941

4042
@Override
43+
@Generated
4144
OffsetDateTime convert(Long value) {
4245
OffsetDateTime.ofInstant(Instant.ofEpochMilli(value), systemOffset)
4346
}

grails-datamapping-core/src/main/groovy/grails/gorm/time/OffsetTimeConverter.groovy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import java.time.OffsetTime
2424
import java.time.ZoneOffset
2525

2626
import groovy.transform.CompileStatic
27+
import groovy.transform.Generated
2728

2829
/**
2930
* A trait to convert a {@link java.time.OffsetTime} to and from a long
@@ -34,11 +35,13 @@ import groovy.transform.CompileStatic
3435
trait OffsetTimeConverter implements TemporalConverter<OffsetTime> {
3536

3637
@Override
38+
@Generated
3739
Long convert(OffsetTime value) {
3840
value.withOffsetSameInstant(ZoneOffset.UTC).toLocalTime().toNanoOfDay()
3941
}
4042

4143
@Override
44+
@Generated
4245
OffsetTime convert(Long value) {
4346
OffsetTime.of(LocalTime.ofNanoOfDay(value), ZoneOffset.UTC).withOffsetSameInstant(systemOffset)
4447
}

grails-datamapping-core/src/main/groovy/grails/gorm/time/PeriodConverter.groovy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ package grails.gorm.time
2222
import java.time.Period
2323

2424
import groovy.transform.CompileStatic
25+
import groovy.transform.Generated
2526

2627
/**
2728
* A trait to convert a {@link java.time.Period} to and from a String
@@ -31,10 +32,12 @@ import groovy.transform.CompileStatic
3132
@CompileStatic
3233
trait PeriodConverter {
3334

35+
@Generated
3436
String convert(Period value) {
3537
value.toString()
3638
}
3739

40+
@Generated
3841
Period convert(String value) {
3942
Period.parse(value)
4043
}

0 commit comments

Comments
 (0)