Fix NullPointerException when servlet version is not set (#12690)

maiconandsilva · web-flow · commit e138700a5480 · 2022-09-08T10:28:28.000-03:00
Metadata.getServletVersion: replace Optional.of for Optional.ofNullable
diff --git a/grails-bootstrap/src/main/groovy/grails/util/Metadata.groovy b/grails-bootstrap/src/main/groovy/grails/util/Metadata.groovy
@@ -281,7 +281,7 @@ class Metadata extends PropertySourcePropertyResolver {
     String getServletVersion() {
         Optional<String> servletVersion = ((PropertyResolver) this).getProperty(SERVLET_VERSION, String.class)
         if (!servletVersion.isPresent()) {
-            servletVersion = Optional.of(System.getProperty(SERVLET_VERSION))
+            servletVersion = Optional.ofNullable(System.getProperty(SERVLET_VERSION))
         }
         servletVersion.orElse(DEFAULT_SERVLET_VERSION)
     }

Original file line number	Diff line number	Diff line change
`@@ -281,7 +281,7 @@ class Metadata extends PropertySourcePropertyResolver {`
`281`	`281`	`String getServletVersion() {`
`282`	`282`	`Optional<String> servletVersion = ((PropertyResolver) this).getProperty(SERVLET_VERSION, String.class)`
`283`	`283`	`if (!servletVersion.isPresent()) {`
`284`		`- servletVersion = Optional.of(System.getProperty(SERVLET_VERSION))`
	`284`	`+ servletVersion = Optional.ofNullable(System.getProperty(SERVLET_VERSION))`
`285`	`285`	`}`
`286`	`286`	`servletVersion.orElse(DEFAULT_SERVLET_VERSION)`
`287`	`287`	`}`