Skip to content

Commit ee99807

Browse files
authored
Merge pull request #15188 from apache/forge-updates
Forge updates
2 parents 0726e82 + 17b3faa commit ee99807

File tree

6 files changed

+14
-27
lines changed

6 files changed

+14
-27
lines changed

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/buildGradle.rocker.raw

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,8 @@ repositories {
9595

9696
@dependencies.template(applicationType, project, features, gradleBuild)
9797

98-
@if(features.contains("geb-with-webdriver-binaries")) {
99-
// geb-with-webdriver-binaries is limited to Gradle 8.6 with max JDK 21
100-
compileJava.options.release = @JdkVersion.valueOf(Math.min(features.javaVersion().majorVersion(), JdkVersion.JDK_21.majorVersion())).majorVersion()
101-
102-
} else {
10398
compileJava.options.release = @features.getTargetJdk()
10499

105-
}
106-
107100
@if (features.contains("jrebel")) {
108101
bootRun {
109102
dependsOn(generateRebel)

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/gradleWrapperProperties.rocker.raw

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,7 @@ Features features)
3333

3434
distributionBase=GRADLE_USER_HOME
3535
distributionPath=wrapper/dists
36-
@if(features.contains("geb-with-webdriver-binaries")) {
37-
# geb-with-webdriver-binaries is limited to Gradle 8.6
38-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
39-
} else {
4036
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
41-
}
4237
networkTimeout=10000
4338
validateDistributionUrl=true
4439
zipStoreBase=GRADLE_USER_HOME

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/test/GebWithWebDriverBinaries.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,13 @@ public String getName() {
5252

5353
@Override
5454
public String getTitle() {
55-
return "Geb Functional Testing for Grails with WebDriver binaries Gradle plugin - no longer maintained";
55+
return "Geb Functional Testing using WebDriver binaries Gradle plugin";
5656
}
5757

5858
@NonNull
5959
@Override
6060
public String getDescription() {
61-
return "This plugins configure Geb for Grails framework to write automation tests with WebDriver binaries Gradle plugin. No longer maintained and limited to Gradle 8.6 and JDK 21. geb-with-testcontainers is the replacement and default starting with Grails 7.";
61+
return "This plugin configures Geb to use the WebDriver binaries Gradle plugin for downloading and caching the WebDriver binary for your platform.";
6262
}
6363

6464
@Override
@@ -96,8 +96,8 @@ public void processSelectedFeatures(FeatureContext featureContext) {
9696
@Override
9797
public void apply(GeneratorContext generatorContext) {
9898
generatorContext.addBuildPlugin(GradlePlugin.builder()
99-
.id("com.github.erdi.webdriver-binaries")
100-
.lookupArtifactId("webdriver-binaries-gradle-plugin")
99+
.id("org.ysb33r.webdriver-binaries")
100+
.lookupArtifactId("webdriver-binaries")
101101
.extension(
102102
new RockerWritable(
103103
webdriverBinariesPlugin.template(
@@ -106,7 +106,6 @@ public void apply(GeneratorContext generatorContext) {
106106
)
107107
)
108108
)
109-
.version("3.2")
110109
.build());
111110

112111
Stream.of("api", "support", "remote-driver")

grails-forge/grails-forge-core/src/main/resources/pom.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,17 @@
3636
<groupId>io.micronaut.platform</groupId>
3737
<artifactId>micronaut-platform</artifactId>
3838
<type>pom</type>
39-
<version>4.9.2</version>
39+
<version>4.10.1</version>
4040
</dependency>
4141
<dependency>
4242
<groupId>org.grails.plugins</groupId>
4343
<artifactId>grails-web-console</artifactId>
44-
<version>7.0.0-M3</version>
44+
<version>7.0.0</version>
4545
</dependency>
4646
<dependency>
4747
<groupId>org.apache.grails</groupId>
4848
<artifactId>grails-quartz</artifactId>
49-
<version>4.0.0-M3</version>
49+
<version>4.0.0</version>
5050
</dependency>
5151
<dependency>
5252
<!-- Last released Feb 24, 2021 -->
@@ -62,12 +62,12 @@
6262
<dependency>
6363
<groupId>com.gradleup.shadow</groupId>
6464
<artifactId>shadow-gradle-plugin</artifactId>
65-
<version>9.0.2</version>
65+
<version>9.2.2</version>
6666
</dependency>
6767
<dependency>
68-
<groupId>com.github.erdi</groupId>
69-
<artifactId>webdriver-binaries-gradle-plugin</artifactId>
70-
<version>3.2</version>
68+
<groupId>org.ysb33r</groupId>
69+
<artifactId>webdriver-binaries</artifactId>
70+
<version>4.0.0</version>
7171
</dependency>
7272
<dependency>
7373
<groupId>org.zeroturnaround</groupId>

grails-forge/grails-forge-core/src/test/groovy/org/grails/forge/feature/test/GebWithWebDriverBinariesSpec.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class GebWithWebDriverBinariesSpec extends ApplicationContextSpec implements Com
6969
def buildGradle = output['build.gradle']
7070

7171
expect:
72-
buildGradle.contains('id "com.github.erdi.webdriver-binaries"')
72+
buildGradle.contains('id "org.ysb33r.webdriver-binaries"')
7373
buildGradle.contains('webdriverBinaries')
7474
buildGradle.contains("chromedriver '122.0.6260.0'")
7575
buildGradle.contains("geckodriver '0.33.0'")
@@ -82,7 +82,7 @@ class GebWithWebDriverBinariesSpec extends ApplicationContextSpec implements Com
8282
def buildGradle = output['build.gradle']
8383

8484
expect:
85-
buildGradle.contains('id "com.github.erdi.webdriver-binaries"')
85+
buildGradle.contains('id "org.ysb33r.webdriver-binaries"')
8686
buildGradle.contains('webdriverBinaries')
8787
buildGradle.contains("chromedriver '122.0.6260.0'")
8888
buildGradle.contains("geckodriver '0.33.0'")

grails-forge/test-core/src/test/groovy/org/grails/forge/create/CreateAppSpec.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ class CreateAppSpec extends CommandSpec {
9191

9292
expect:
9393
gradleProperties.exists()
94-
gradleProperties.text.contains('micronautPlatformVersion=4.9.2')
94+
gradleProperties.text.contains('micronautPlatformVersion=4.10.1')
9595
gradleBuildFile.exists()
9696
gradleBuildFile.text.contains('implementation "org.apache.grails:grails-micronaut"')
9797
}

0 commit comments

Comments
 (0)