Rename AutoTimestampUtils to AuditMetadataUtils and log debug ignored exceptions

Author: codeconsole

grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/events/AutoTimestampEventListener.java

@@ -48,7 +48,7 @@
 import org.grails.datastore.mapping.engine.event.EventType;
 import org.grails.datastore.mapping.engine.event.PreInsertEvent;
 import org.grails.datastore.mapping.engine.event.PreUpdateEvent;
-import org.grails.datastore.mapping.model.AutoTimestampUtils;
+import org.grails.datastore.mapping.model.AuditMetadataUtils;
 import org.grails.datastore.mapping.model.ClassMapping;
 import org.grails.datastore.mapping.model.MappingContext;
 import org.grails.datastore.mapping.model.PersistentEntity;
@@ -249,7 +249,7 @@ protected void storeDateCreatedAndLastUpdatedInfo(PersistentEntity persistentEnt
                     } else if (property.getName().equals(DATE_CREATED_PROPERTY)) {
                         storeTimestampAvailability(entitiesWithDateCreated, persistentEntity, property);
                     } else {
-                        AuditMetadataType auditMetadataType = AutoTimestampUtils.getAuditMetadataType(property, cacheAutoTimestampAnnotations);
+                        AuditMetadataType auditMetadataType = AuditMetadataUtils.getAuditMetadataType(property, cacheAutoTimestampAnnotations);
                         if (auditMetadataType == AuditMetadataType.CREATED) {
                             storeTimestampAvailability(entitiesWithDateCreated, persistentEntity, property);
                         } else if (auditMetadataType == AuditMetadataType.UPDATED) {

grails-datamapping-validation/src/main/groovy/org/grails/datastore/gorm/validation/constraints/eval/DefaultConstraintEvaluator.java

@@ -49,7 +49,7 @@
 import org.grails.datastore.mapping.config.AuditMetadataType;
 import org.grails.datastore.mapping.config.Property;
 import org.grails.datastore.mapping.keyvalue.mapping.config.KeyValueMappingContext;
-import org.grails.datastore.mapping.model.AutoTimestampUtils;
+import org.grails.datastore.mapping.model.AuditMetadataUtils;
 import org.grails.datastore.mapping.model.MappingContext;
 import org.grails.datastore.mapping.model.PersistentEntity;
 import org.grails.datastore.mapping.model.PersistentProperty;
@@ -316,7 +316,7 @@ protected boolean isConstrainableProperty(PersistentProperty persistentProperty,
             // Check if property has @CreatedDate or @LastModifiedDate annotations
             // Note: We only exclude timestamp date fields (CREATED/UPDATED), not auditor fields (CREATED_BY/UPDATED_BY)
             // because auditor fields can have various types and should support constraints (e.g., maxSize for String)
-            AuditMetadataType auditMetadataType = AutoTimestampUtils.getAuditMetadataType(persistentProperty, cacheAutoTimestampAnnotations);
+            AuditMetadataType auditMetadataType = AuditMetadataUtils.getAuditMetadataType(persistentProperty, cacheAutoTimestampAnnotations);
             if (auditMetadataType == AuditMetadataType.CREATED || auditMetadataType == AuditMetadataType.UPDATED) {
                 return false;
             }

…re/mapping/model/AutoTimestampUtils.java …re/mapping/model/AuditMetadataUtils.javagrails-datastore-core/src/main/groovy/org/grails/datastore/mapping/model/AutoTimestampUtils.java renamed to grails-datastore-core/src/main/groovy/org/grails/datastore/mapping/model/AuditMetadataUtils.java grails-datastore-core/src/main/groovy/org/grails/datastore/mapping/model/AutoTimestampUtils.java renamed to grails-datastore-core/src/main/groovy/org/grails/datastore/mapping/model/AuditMetadataUtils.java

@@ -20,13 +20,15 @@
 
 import java.lang.reflect.Field;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.util.ReflectionUtils;
 
 import org.grails.datastore.mapping.config.AuditMetadataType;
 import org.grails.datastore.mapping.config.Property;
 
 /**
- * Utility class for detecting and caching auto-timestamp and auditing annotations on domain properties.
+ * Utility class for detecting and caching audit metadata annotations on domain properties.
  * This avoids repeated reflection calls by storing the annotation type in the Property metadata.
  *
  * <p>Supports the following annotations (both GORM and Spring Data variants):</p>
@@ -46,7 +48,9 @@
  * @author Scott Murphy Heiberg
  * @since 7.1
  */
-public class AutoTimestampUtils {
+public class AuditMetadataUtils {
+
+    private static final Logger LOG = LoggerFactory.getLogger(AuditMetadataUtils.class);
 
     private static final String CREATED_DATE_ANNOTATION = "grails.gorm.annotation.CreatedDate";
     private static final String LAST_MODIFIED_DATE_ANNOTATION = "grails.gorm.annotation.LastModifiedDate";
@@ -145,14 +149,23 @@ private static AuditMetadataType detectAuditMetadataType(PersistentProperty<?> p
                                 }
                             } catch (Exception e) {
                                 // If we can't read the value, default to CREATED
+                                if (LOG.isDebugEnabled()) {
+                                    LOG.debug("Failed to read @AutoTimestamp EventType value for property [{}], defaulting to CREATED",
+                                            persistentProperty.getName(), e);
+                                }
                                 return AuditMetadataType.CREATED;
                             }
                             break;
                     }
                 }
             }
-        } catch (Exception ignored) {
+        } catch (Exception e) {
             // If reflection fails, return NONE
+            if (LOG.isDebugEnabled()) {
+                LOG.debug("Failed to detect audit metadata annotations for property [{}] on entity [{}]",
+                        persistentProperty.getName(),
+                        persistentProperty.getOwner().getName(), e);
+            }
         }
 
         return AuditMetadataType.NONE;

grails-fields/src/main/groovy/org/grails/scaffolding/model/DomainModelServiceImpl.groovy

@@ -29,7 +29,7 @@ import org.springframework.beans.factory.annotation.Value
 import grails.util.GrailsClassUtils
 import org.grails.datastore.mapping.config.Property
 import org.grails.datastore.mapping.config.Settings
-import org.grails.datastore.mapping.model.AutoTimestampUtils
+import org.grails.datastore.mapping.model.AuditMetadataUtils
 import org.grails.datastore.mapping.model.PersistentEntity
 import org.grails.datastore.mapping.model.PersistentProperty
 import org.grails.datastore.mapping.model.types.Embedded
@@ -153,7 +153,7 @@ class DomainModelServiceImpl implements DomainModelService {
         // Add properties with audit metadata annotations to blacklist only if excludeAnnotatedTimestamps is true
         if (excludeAnnotatedTimestamps) {
             properties.each { DomainProperty property ->
-                if (AutoTimestampUtils.hasAuditMetadataAnnotation(property.persistentProperty, cacheAutoTimestampAnnotations)) {
+                if (AuditMetadataUtils.hasAuditMetadataAnnotation(property.persistentProperty, cacheAutoTimestampAnnotations)) {
                     if (!blacklist.contains(property.name)) {
                         blacklist.add(property.name)
                     }