7.0.0-SNAPSHOT request/params binding stopped working on 2025-02-17T00:49:38Z

[codeconsole]

Expected Behavior

This has always worked, but stopped working after 2025-02-17T00:49:38Z

request and params are no longer bound when using Groovy .with {} on.a domain object inside a controller.

class OrderController {

    def process() {
        def order = new Order() 
        order.with {
            firstName           = request.currentUser.firstName
            lastName            = equest.currentUser.lastName

            billingPhone        = params.billing_phone
            billingAddress1     = params.billing_address1
            billingAddress2     = params.billing_address2
        }
    }
 }

Actual Behaviour

No response

Steps To Reproduce

No response

Environment Information

No response

Example Application

No response

Version

7.0.0-SNAPSHOT

[jeffscottbrown]

7.0.0-SNAPSHOT request/params binding stopped working on 2025-02-17T00:49:38Z

How did you narrow down that specific point in time?

[jdaugherty]

I know that when this PR (#13984) was merged, it broke several builds. We fixed the builds last week so it's possible you finally got the build in your environment?

We discussed this in weekly meeting and we don't want to merge these changes without a larger discussion going forward (due to the impact and mismatch with spring's bom).

[codeconsole]

@jeffscottbrown that is my last known working release

[jeffscottbrown]

@jeffscottbrown that is my last known working release

Do you know when the first broken release was built?

[codeconsole]

We only discovered it through manual testing so in the last couple of hours. so it could have been anytime in the last 43 hours.

[codeconsole]

Replication Steps

git clone https://github.com/codeconsole/grails-autotimestamp-bug
cd demo7
sdk env
./gradle clean bootRun

http://localhost:8080/sample/failedBinding.json

[matrei]

I might be missing something, but I can't seem to replicate the problem:

http://localhost:8080/sample/failedBinding.json
http://localhost:8080/sample/failedBinding.json?name=Mattias

{"dateCreated":null,"name":null}
{"dateCreated":null,"name":"Mattias"}

Grails application running at http://localhost:8080 in environment: development
2025-02-19T09:03:31.394+01:00  INFO 415945 --- [nio-8080-exec-1] com.example.SampleController             : sample.name 'null' should not be null.
2025-02-19T09:03:48.760+01:00  INFO 415945 --- [nio-8080-exec-2] com.example.SampleController             : sample.name 'Mattias' should not be null.

[jeffscottbrown]

I might be missing something, but I can't seem to replicate the problem

I am seeing the same thing. The name request param does appear to be properly bound when I run the app locally.

[jeffscottbrown]

@codeconsole Do the tests at https://github.com/jeffscottbrown/bindingissueusingwith/blob/3188e160ef3af5689792bdbe6c7cfb950899aaab/src/test/groovy/com/example/DemoControllerSpec.groovy#L14-L34 pass for you when run locally?

[jdaugherty]

This doesn't appear to be an issue any longer, so I'm closing.