#1294 Added Tests for dirty checking and proxy

to demonstrate the need to override equals method for correctly marking association as dirty or not.

Author: puneetbehl

grails-datastore-gorm-test/src/test/groovy/org/grails/datastore/gorm/DirtyCheckingSpec.groovy

@@ -1,7 +1,7 @@
 package org.grails.datastore.gorm
 
+import grails.gorm.annotation.Entity
 import grails.gorm.tests.GormDatastoreSpec
-
 import grails.gorm.tests.Person
 import org.grails.datastore.mapping.dirty.checking.DirtyCheckable
 
@@ -10,6 +10,17 @@ import org.grails.datastore.mapping.dirty.checking.DirtyCheckable
  */
 class DirtyCheckingSpec extends GormDatastoreSpec {
 
+    def proxyHandler
+
+    @Override
+    List getDomainClasses() {
+        [Person, TestBook, TestAuthor]
+    }
+
+    def setup() {
+        proxyHandler = session.getMappingContext().proxyHandler
+    }
+
     void "Test that dirty checking methods work when changing entities"() {
         when:"A new instance is created"
             def p = new Person(firstName: "Homer", lastName: "Simpson")
@@ -53,4 +64,72 @@ class DirtyCheckingSpec extends GormDatastoreSpec {
 
 
     }
+
+    void "test relationships not marked dirty when proxies are used"() {
+
+        given:
+        Long bookId = new TestBook(title: 'Martin Fierro', author: new TestAuthor(name: 'Jose Hernandez'))
+                .save(flush: true)
+                .id
+        session.flush()
+        session.clear()
+
+        when:
+        TestBook book = TestBook.get(bookId)
+        book.author = book.author
+
+        then:
+        proxyHandler.isProxy(book.author)
+        !book.isDirty('author')
+        !book.isDirty()
+
+        cleanup:
+        TestBook.deleteAll()
+        TestAuthor.deleteAll()
+    }
+
+    void "test relationships not marked dirty when domain objects are used"() {
+
+        given:
+        Long bookId = new TestBook(title: 'Martin Fierro', author: new TestAuthor(name: 'Jose Hernandez'))
+                .save(flush: true, failOnError: true)
+                .id
+        session.flush()
+        session.clear()
+
+        when:
+        TestBook book = TestBook.get(bookId)
+        book.author = TestAuthor.get(book.authorId)
+
+        then:
+        !proxyHandler.isProxy(book.author)
+        !book.isDirty('author')
+        !book.isDirty()
+
+        cleanup:
+        TestBook.deleteAll()
+        TestAuthor.deleteAll()
+    }
+}
+
+@Entity
+class TestAuthor {
+    String name
+    long version
+
+    @Override
+    boolean equals(o) {
+        if (!(o instanceof TestAuthor)) return false
+        if (this.is(o)) return true
+        TestAuthor that = (TestAuthor) o
+        if (id !=null && that.id !=null) return id == that.id
+        return false
+    }
+}
+
+@Entity
+class TestBook {
+    String title
+    long version
+    TestAuthor author
 }