Update ConstraintsSpec

Declared qualified name for the constants inside Grails constraints closure.

Author: puneetbehl

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tests/ConstraintsSpec.groovy

@@ -5,14 +5,14 @@ import grails.persistence.Entity
 class ConstraintsSpec extends GormDatastoreSpec {
 
     void "Test constraints with static default values"() {
-         given: "A Test class with static constraint values"
-            def ce = new ConstrainedEntity(num:1000, str:"ABC")
+        given: "A Test class with static constraint values"
+        def ce = new ConstrainedEntity(num: 1000, str: "ABC")
 
-         when: "saved is called"
-            ce.save()
+        when: "saved is called"
+        ce.save()
 
-         then:
-            ce.hasErrors() == false
+        then:
+        !ce.hasErrors()
     }
 
     @Override
@@ -21,6 +21,7 @@ class ConstraintsSpec extends GormDatastoreSpec {
     }
 }
 
+@SuppressWarnings(["ClashingTraitMethods", "UnnecessaryQualifiedReference"])
 @Entity
 class ConstrainedEntity implements Serializable {
 
@@ -33,9 +34,9 @@ class ConstrainedEntity implements Serializable {
 
     static constraints = {
 
-        num(maxSize: MAX_VALUE) /*Must be MyDomainClass.MAX_VALUE in order work with redis*/
+        num(maxSize: ConstrainedEntity.MAX_VALUE)
         str validator: { val, obj ->
-            if (val != null && !ALLOWABLE_VALUES.contains(val)) {/*Must be MyDomainClass.ALLOWABLE_VALUES in order work with redis */
+            if (val != null && !ConstrainedEntity.ALLOWABLE_VALUES.contains(val)) {
                 return ['not.valid']
             }
         }