test: replace @Ignore with @PendingFeature

- Use `@PendingFeature` so that the build fails if the test unexpectedly succeeds, providing an alert that the test passes.

Author: matrei

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tests/CriteriaBuilderSpec.groovy

@@ -1,6 +1,6 @@
 package grails.gorm.tests
 
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 
 /**
  * Abstract base test for criteria queries. Subclasses should do the necessary setup to configure GORM
@@ -31,7 +31,7 @@ class CriteriaBuilderSpec extends GormDatastoreSpec {
             result == 4
     }
 
-    @Ignore // ignored this test because the id() projection does not actually exist in GORM for Hibernate
+    @PendingFeature(reason = 'ignored this test because the id() projection does not actually exist in GORM for Hibernate')
     void "Test id projection"() {
         given:
             def entity = new TestEntity(name:"Bob", age: 44, child:new ChildEntity(name:"Child")).save(flush:true)

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tests/DomainEventsSpec.groovy

@@ -4,7 +4,7 @@ import grails.gorm.DetachedCriteria
 import grails.persistence.Entity;
 import spock.lang.Issue
 
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 
 /**
  * @author graemerocher
@@ -265,7 +265,7 @@ class DomainEventsSpec extends GormDatastoreSpec {
             3 == PersonEvent.STORE.afterLoad
     }
 
-    @Ignore
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "Test bean autowiring"() {
         given:
             def personService = new Object()

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tests/FirstAndLastMethodSpec.groovy

@@ -2,11 +2,11 @@ package grails.gorm.tests
 
 import grails.persistence.Entity
 
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 
-@Ignore
 class FirstAndLastMethodSpec extends GormDatastoreSpec {
 
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "Test first and last method with empty datastore"() {
         given:
         assert SimpleWidget.count() == 0
@@ -24,6 +24,7 @@ class FirstAndLastMethodSpec extends GormDatastoreSpec {
         result == null
     }
 
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "Test first and last method with multiple entities in the datastore"() {
         given:
         assert new SimpleWidget(name: 'one', spanishName: 'uno').save()
@@ -44,6 +45,7 @@ class FirstAndLastMethodSpec extends GormDatastoreSpec {
         result?.name == 'three'
     }
 
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "Test first and last method with one entity"() {
         given:
         assert new SimpleWidget(name: 'one', spanishName: 'uno').save()
@@ -62,6 +64,7 @@ class FirstAndLastMethodSpec extends GormDatastoreSpec {
         result?.name == 'one'
     }
 
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "Test first and last method with sort parameter"() {
         given:
         assert new SimpleWidget(name: 'one', spanishName: 'uno').save()
@@ -118,6 +121,7 @@ class FirstAndLastMethodSpec extends GormDatastoreSpec {
         result?.spanishName == 'uno'
     }
 
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "Test first and last method with non standard identifier"() {
         given:
         ['one', 'two', 'three'].each { name ->
@@ -138,6 +142,7 @@ class FirstAndLastMethodSpec extends GormDatastoreSpec {
         result?.name == 'three'
     }
 
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "Test first and last method with composite key"() {
         given:
         assert new PersonWithCompositeKey(firstName: 'Steve', lastName: 'Harris', age: 56).save()

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tests/GormEnhancerSpec.groovy

@@ -1,6 +1,6 @@
 package grails.gorm.tests
 
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 
 /**
  * @author graemerocher
@@ -160,7 +160,7 @@ class GormEnhancerSpec extends GormDatastoreSpec {
             results.find { it.name == "Frank" } != null
     }
 
-    @Ignore
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "Test ilike query"() {
         given:
             def age = 40

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tests/NamedQuerySpec.groovy

@@ -424,7 +424,7 @@ class NamedQuerySpec extends GormDatastoreSpec {
             'Some Recent Book' == publications[2].title
     }
 
-    @Ignore  // queries on associations not yet supported
+    @PendingFeature(reason = 'queries on associations not yet supported')
     void "Test named query with relationships in criteria"() {
 
         given:
@@ -467,7 +467,7 @@ class NamedQuerySpec extends GormDatastoreSpec {
             'groovy' == results[0].name
     }
 
-    @Ignore  // queries on associations not yet supported
+    @PendingFeature(reason = 'queries on associations not yet supported')
     void "Test list distinct entities"() {
 
         given:
@@ -499,7 +499,7 @@ class NamedQuerySpec extends GormDatastoreSpec {
             true == 'orange' in names
     }
 
-    @Ignore  // queries on associations not yet supported
+    @PendingFeature(reason = 'queries on associations not yet supported')
     void "Another test on listing distinct entities"() {
         given:
             new PlantCategory(name:"leafy")
@@ -681,8 +681,7 @@ class NamedQuerySpec extends GormDatastoreSpec {
             'Some New Book' == publications[0].title
     }
 
-    // findby boolean queries not yet supported
-    @Ignore
+    @PendingFeature(reason = 'findby boolean queries not yet supported')
     void "Test named query with findAll by boolean property"() {
         given:
             def Publication = ga.getDomainClass("Publication").clazz
@@ -702,8 +701,7 @@ class NamedQuerySpec extends GormDatastoreSpec {
             publications[1].title == 'Some Book'
     }
 
-    // findby boolean queries not yet supported
-    @Ignore
+    @PendingFeature(reason = 'findby boolean queries not yet supported')
     void "Test named query with find by boolean property"() {
 
         given:
@@ -741,7 +739,7 @@ class NamedQuerySpec extends GormDatastoreSpec {
             3 == numberOfNewBooksNamedSomeBook
     }
 
-    @Ignore // list order by not yet supported
+    @PendingFeature(reason = 'list order by not yet supported')
     void "Test named query with listOrderBy*() dynamic finder"() {
 
         given:
@@ -825,7 +823,7 @@ class NamedQuerySpec extends GormDatastoreSpec {
             publication == null
     }
 
-    @Ignore
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "Test count method following named criteria"() {
 
         given:

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tests/QueryEventsSpec.groovy

@@ -6,12 +6,11 @@ import org.grails.datastore.mapping.query.event.PostQueryEvent
 import org.grails.datastore.mapping.query.event.PreQueryEvent
 import org.springframework.context.ApplicationEvent
 import org.springframework.context.event.SmartApplicationListener
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 
 /**
  * Tests for query events.
  */
-@Ignore
 class QueryEventsSpec extends GormDatastoreSpec {
     SpecQueryEventListener listener
 
@@ -25,6 +24,7 @@ class QueryEventsSpec extends GormDatastoreSpec {
         session.datastore.applicationContext.addApplicationListener(listener)
     }
 
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "pre-events are fired before queries are run"() {
         when:
         TestEntity.findByName 'bob'
@@ -45,6 +45,7 @@ class QueryEventsSpec extends GormDatastoreSpec {
         listener.PreExecution == 3
     }
 
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "post-events are fired after queries are run"() {
         given:
         def entity = new TestEntity(name: 'bob').save(flush: true)

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tests/SessionCreationEventSpec.groovy

@@ -4,12 +4,11 @@ import org.springframework.context.event.SmartApplicationListener
 import org.springframework.context.ApplicationEvent
 import org.grails.datastore.mapping.core.SessionCreationEvent
 import org.grails.datastore.mapping.core.Session
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 
 /**
  * Test case that session creation events are fired.
  */
-@Ignore
 class SessionCreationEventSpec extends GormDatastoreSpec {
 
     Listener listener
@@ -19,6 +18,7 @@ class SessionCreationEventSpec extends GormDatastoreSpec {
         session.datastore.applicationContext.addApplicationListener(listener)
     }
 
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "test event for new session"() {
         when:"Using existing session"
         TestEntity.withSession { s ->

grails-datastore-gorm-test/src/test/groovy/grails/gorm/tests/WhereMethodSpec.groovy

@@ -1195,7 +1195,8 @@ class Project {
 
    }
 
-   @Ignore // rlike not suppported by all datastores yet
+   // Could we use @PendingFeatureIf here?
+   @Ignore('rlike not supported by all datastores yet')
    def "Test rlike query"() {
        given:"A bunch of people"
             createPeople()

grails-datastore-gorm-test/src/test/groovy/org/grails/datastore/gorm/CompositeIdentifierSpec.groovy

@@ -3,14 +3,14 @@ package org.grails.datastore.gorm
 import grails.gorm.tests.GormDatastoreSpec
 import grails.persistence.Entity
 
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 
 /**
  * TODO: Support composite ids
  */
-@Ignore
 class CompositeIdentifierSpec extends GormDatastoreSpec {
 
+    @PendingFeature(reason = 'Composite ids not supported')
     void "Test that a composite identifier is treated as assigned"() {
         given:"A domain model with a composite identifier"
             def u = new User(name: "Bob").save()

grails-datastore-gorm-test/src/test/groovy/org/grails/datastore/gorm/CustomTypeMarshallingSpec.groovy

@@ -2,8 +2,8 @@ package org.grails.datastore.gorm
 
 import grails.gorm.tests.GormDatastoreSpec
 import grails.persistence.Entity
-import spock.lang.Ignore
 import spock.lang.Issue
+import spock.lang.PendingFeature
 import spock.lang.Shared
 
 class CustomTypeMarshallingSpec extends GormDatastoreSpec {
@@ -50,7 +50,7 @@ class CustomTypeMarshallingSpec extends GormDatastoreSpec {
     }
 
     @Issue("http://jira.grails.org/browse/GRAILS-8436")
-    @Ignore
+    @PendingFeature(reason = 'Was previously @Ignore')
     void "can re-save an existing instance without modifications"() {
         given:
             def p = Person.findByName("Fred")