#1294 Revert changes related to comparing proxy in DirtyCheckable

Author: puneetbehl

grails-datastore-core/src/main/groovy/org/grails/datastore/mapping/dirty/checking/DirtyCheckable.groovy

@@ -91,18 +91,13 @@ trait DirtyCheckable {
         if( $changedProperties != null && !$changedProperties.containsKey(propertyName))  {
             boolean isNull = newValue == null
             if ((isNull && oldValue != null) ||
-                (!isNull && oldValue == null) ||
-                (!isNull && (newOldOrOldValueIsProxy(newValue, oldValue) && newValue.getAt("id") != oldValue.getAt("id")
-                        || (!newOldOrOldValueIsProxy(newValue, oldValue) && !newValue.equals(oldValue))))) {
+                    (!isNull && oldValue == null) ||
+                    (!isNull && !newValue.equals(oldValue))) {
                 $changedProperties.put propertyName, oldValue
             }
         }
     }
 
-    boolean newOldOrOldValueIsProxy(newValue, oldValue) {
-        (newValue instanceof EntityProxy || oldValue instanceof EntityProxy)
-    }
-
     /**
      * @return A list of the dirty property names
      */

grails-datastore-gorm-test/src/test/groovy/org/grails/datastore/gorm/DirtyCheckingSpec.groovy

@@ -162,6 +162,15 @@ class DirtyCheckingSpec extends GormDatastoreSpec {
 @Entity
 class TestAuthor {
     String name
+
+    @Override
+    boolean equals(o) {
+        if (!(o instanceof TestAuthor)) return false
+        if (this.is(o)) return true
+        TestAuthor that = (TestAuthor) o
+        if (id !=null && that.id !=null) return id == that.id
+        return false
+    }
 }
 
 @Entity