feedback: styling & removing debug

Author: jdaugherty

docs/guide-developer/src/main/docs/stepByStep.adoc

@@ -32,7 +32,7 @@ dependencies {
             project(':grails-datastore-web'),
             project(':grails-datastore-gorm-support')
             
-    testImplementation project(':grails-datastore-gorm-tck').testFixtures
+    testImplementation project(':grails-datastore-gorm-tck')
     testRuntime "javax.servlet:javax.servlet-api:$servletApiVersion"
 
 }

docs/guide-developer/src/main/docs/testing.adoc

@@ -2,7 +2,7 @@ The `grails-datastore-gorm-tck` project provides several hundred tests to guaran
 
 [source,groovy]
 ----
-testCompile project(':grails-datastore-gorm-tck').testFixtures
+testCompile project(':grails-datastore-gorm-tck')
 ----
 
 Then create a `Setup.groovy` file that sets up your custom datastore in your implementation.

gradle/tck-config.gradle

@@ -1,17 +1,16 @@
 dependencies {
-    if(!project.hasProperty('includeBaseTckClass') || project.findProperty('includeBaseTckClass')) {
+    if (!project.hasProperty('includeBaseTckClass') || project.findProperty('includeBaseTckClass')) {
         testImplementation project(':grails-datastore-gorm-tck-base')
     }
-//    testImplementation project(path: ':grails-datastore-gorm-tck', configuration: 'testArtifacts')
     testImplementation project(':grails-datastore-gorm-tck')
     testImplementation project(':grails-datastore-gorm-tck-domains')
 }
 
 // TODO: gradle will happily put the jar file on the classpath, but junit won't find the tests.  Dynamic test discovery also won't find them.
-tasks.register("extractTckJar", Copy) {
+tasks.register('extractTckJar', Copy) {
     dependsOn(configurations.testRuntimeClasspath)
 
-    Provider<Directory> extractTarget = layout.buildDirectory.dir("extracted-tck-classes")
+    Provider<Directory> extractTarget = layout.buildDirectory.dir('extracted-tck-classes')
 
     doFirst {
         extractTarget.get().asFile.deleteDir()
@@ -26,8 +25,8 @@ tasks.register("extractTckJar", Copy) {
 }
 
 tasks.withType(Test).configureEach {
-    dependsOn("extractTckJar")
+    dependsOn('extractTckJar')
     doFirst {
-        testClassesDirs += files(layout.buildDirectory.dir("extracted-tck-classes"))
+        testClassesDirs += files(layout.buildDirectory.dir('extracted-tck-classes'))
     }
 }

grails-data-graphql/examples/spring-boot-app/build.gradle

@@ -3,7 +3,7 @@ buildscript {
 		mavenCentral()
 	}
 	dependencies {
-		implementation platform("org.grails:grails-bom:$grailsVersion")
+		classpath platform("org.grails:grails-bom:$grailsVersion")
 		classpath("org.springframework.boot:spring-boot-gradle-plugin")
 	}
 }

grails-data-hibernate5/gorm/src/test/groovy/grails/gorm/tests/GormDatastoreSpec.groovy

@@ -25,6 +25,7 @@ import grails.gorm.tck.PlantCategory
 import grails.gorm.tck.Publication
 import grails.gorm.tck.Task
 import grails.gorm.tck.TestEntity
+import groovy.util.logging.Slf4j
 import org.grails.datastore.mapping.core.DatastoreUtils
 import org.grails.datastore.mapping.core.Session
 import spock.lang.Shared
@@ -42,6 +43,7 @@ import spock.lang.Specification
  * This class must contain a static no-arg method called "setup()"
  * that returns a Session instance.
  */
+@Slf4j
 abstract class GormDatastoreSpec extends Specification {
 
     static final CURRENT_TEST_NAME = "current.gorm.test"
@@ -61,7 +63,7 @@ abstract class GormDatastoreSpec extends Specification {
     }
 
     def setup() {
-        System.out.println("Using hibernate5 datastore class")
+        log.info('Using hibernate5 datastore class')
         cleanRegistry()
         System.setProperty(CURRENT_TEST_NAME, this.getClass().simpleName - 'Spec')
         session = createSession()

grails-data-hibernate5/gorm/src/test/groovy/org/grails/datastore/gorm/Setup.groovy

@@ -69,7 +69,7 @@ class Setup {
     }
 
     static Session setup(List<Class> classes, ConfigObject grailsConfig = new ConfigObject(), boolean isTransactional = true) {
-        System.setProperty("hibernate5.gorm.suite", "true")
+        System.setProperty('hibernate5.gorm.suite', "true")
         grailsApplication = new DefaultGrailsApplication(classes as Class[], new GroovyClassLoader(Setup.getClassLoader()))
         if(grailsConfig) {
             grailsApplication.config.putAll(grailsConfig)

grails-datastore-gorm-tck-base/src/main/groovy/grails/gorm/tests/GormDatastoreSpec.groovy

@@ -25,6 +25,7 @@ import grails.gorm.tck.PlantCategory
 import grails.gorm.tck.Publication
 import grails.gorm.tck.Task
 import grails.gorm.tck.TestEntity
+import groovy.util.logging.Slf4j
 import org.grails.datastore.mapping.core.DatastoreUtils
 import org.grails.datastore.mapping.core.Session
 
@@ -43,9 +44,10 @@ import spock.lang.Specification
  * This class must contain a static no-arg method called "setup()"
  * that returns a Session instance.
  */
+@Slf4j
 abstract class GormDatastoreSpec extends Specification {
 
-    static final CURRENT_TEST_NAME = "current.gorm.test"
+    static final CURRENT_TEST_NAME = 'current.gorm.test'
     static final SETUP_CLASS_NAME = 'org.grails.datastore.gorm.Setup'
     static final TEST_CLASSES = [
             Book, ChildEntity, City, ClassWithListArgBeforeValidate, ClassWithNoArgBeforeValidate,
@@ -62,7 +64,7 @@ abstract class GormDatastoreSpec extends Specification {
     }
 
     def setup() {
-        System.out.println("Using base datastore class")
+        log.info('Using base datastore class')
         cleanRegistry()
         System.setProperty(CURRENT_TEST_NAME, this.getClass().simpleName - 'Spec')
         session = createSession()

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tck/BuiltinUniqueConstraintWorksWithTargetProxiesConstraintsSpec.groovy

@@ -5,7 +5,7 @@ import org.grails.datastore.mapping.proxy.ProxyHandler
 import spock.lang.PendingFeatureIf
 
 class BuiltinUniqueConstraintWorksWithTargetProxiesConstraintsSpec extends GormDatastoreSpec {
-    @PendingFeatureIf({ !Boolean.getBoolean("hibernate5.gorm.suite") && !Boolean.getBoolean("hibernate6.gorm.suite") && !Boolean.getBoolean("mongodb.gorm.suite")})
+    @PendingFeatureIf({ !Boolean.getBoolean('hibernate5.gorm.suite') && !Boolean.getBoolean('hibernate6.gorm.suite') && !Boolean.getBoolean('mongodb.gorm.suite')})
     void "test unique constraint on root instance"() {
 
         setup:
@@ -26,7 +26,7 @@ class BuiltinUniqueConstraintWorksWithTargetProxiesConstraintsSpec extends GormD
         ContactDetails.deleteAll(contactDetails1)
     }
 
-    @PendingFeatureIf({ !Boolean.getBoolean("hibernate5.gorm.suite") && !Boolean.getBoolean("hibernate6.gorm.suite") && !Boolean.getBoolean("mongodb.gorm.suite")})
+    @PendingFeatureIf({ !Boolean.getBoolean('hibernate5.gorm.suite') && !Boolean.getBoolean('hibernate6.gorm.suite') && !Boolean.getBoolean('mongodb.gorm.suite')})
     void "test unique constraint for the associated child object"() {
 
         setup:

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tck/DirtyCheckingAfterListenerSpec.groovy

@@ -35,7 +35,7 @@ class DirtyCheckingAfterListenerSpec extends GormDatastoreSpec {
         }
     }
 
-    @PendingFeatureIf({ !Boolean.getBoolean("hibernate5.gorm.suite") && !Boolean.getBoolean("hibernate6.gorm.suite") && !Boolean.getBoolean("mongodb.gorm.suite") })
+    @PendingFeatureIf({ !Boolean.getBoolean('hibernate5.gorm.suite') && !Boolean.getBoolean('hibernate6.gorm.suite') && !Boolean.getBoolean('mongodb.gorm.suite') })
     void "test state change from listener update the object"() {
 
         when:

grails-datastore-gorm-tck/src/main/groovy/grails/gorm/tck/DirtyCheckingSpec.groovy

@@ -152,7 +152,7 @@ class DirtyCheckingSpec extends GormDatastoreSpec {
         TestAuthor.deleteAll()
     }
 
-    @IgnoreIf({ !Boolean.getBoolean("mongodb.gorm.suite")})
+    @IgnoreIf({ !Boolean.getBoolean('mongodb.gorm.suite')})
     void "test initialized proxy is not marked as dirty"() {
 
         given: