#1368 - respect FactoryBean.getObjectType contract, use context classloader where appropriate

- DatastoreServiceMethodInvokingFactoryBean.getObjectType returns null if not initialized (i.e. arguments is null, getArguments() returns Object[]). that allows AbstractAutowireCapableBeanFactory to initialize DatastoreServiceMethodInvokingFactoryBean if necessary

- AbstractDatastoreInitializer and SoftServiceLoader use the context classloader to load data service classes. this way, autowiring data services by type works reliably with spring boot devtools restart (RestartClassLoader)

Author: zyro23

grails-datastore-core/src/main/groovy/org/grails/datastore/mapping/config/DatastoreServiceMethodInvokingFactoryBean.groovy

@@ -22,7 +22,10 @@ class DatastoreServiceMethodInvokingFactoryBean extends MethodInvokingFactoryBea
 
     @Override
     Class<?> getObjectType() {
-        arguments[0] as Class<?>
+        if (arguments) {
+            return arguments[0] as Class<?>
+        }
+        return null
     }
 
     @Override

grails-datastore-core/src/main/groovy/org/grails/datastore/mapping/services/SoftServiceLoader.java

@@ -88,7 +88,7 @@ public static Logger getLogger(Class type) {
      * @return A new service loader
      */
     public static <S> SoftServiceLoader<S> load(Class<S> service) {
-        return SoftServiceLoader.load(service, SoftServiceLoader.class.getClassLoader());
+        return SoftServiceLoader.load(service, Thread.currentThread().getContextClassLoader());
     }
 
     /**

grails-datastore-gorm/src/main/groovy/org/grails/datastore/gorm/bootstrap/AbstractDatastoreInitializer.groovy

@@ -333,8 +333,7 @@ abstract class AbstractDatastoreInitializer implements ResourceLoaderAware{
 
     private Class<?> loadServiceClass(Class<Service> clazz) {
         final String serviceClassName = clazz.package.getName() + '.' + clazz.simpleName[1..-15]
-        final ClassLoader cl = org.grails.datastore.mapping.reflect.ClassUtils.classLoader
-        final Class<?> serviceClass = cl.loadClass(serviceClassName)
+        final Class<?> serviceClass = classLoader.loadClass(serviceClassName)
         serviceClass
     }