Skip to content

Commit c432a1e

Browse files
authored
Merge pull request #1873 from grails/matrei/fix-deps
Update Project dependencies and Publishing
2 parents 7f15f74 + d8b16d4 commit c432a1e

File tree

4 files changed

+21
-26
lines changed

4 files changed

+21
-26
lines changed

gradle/publish-config.gradle

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import org.grails.gradle.plugin.publishing.GrailsPublishExtension
22

33
apply plugin: 'org.grails.grails-publish'
44

5-
project.extensions.configure(GrailsPublishExtension) {
5+
extensions.configure(GrailsPublishExtension) {
6+
// Explicit `it` is required here
67
it.githubSlug = 'grails/grails-data-mapping'
78
it.license.name = 'Apache-2.0'
89
it.title = findProperty('pomTitle') ?: 'Grails GORM'
@@ -16,3 +17,18 @@ project.extensions.configure(GrailsPublishExtension) {
1617
'jamesfredley': 'James Fredley'
1718
]
1819
}
20+
21+
// Add sources and javadoc jar tasks
22+
// java.withSourcesJar() and java.withJavadocJar() is not compatible here with GrailsPublishPlugin
23+
if (!tasks.findByName('sourcesJar')) {
24+
tasks.register('sourcesJar', Jar) {
25+
archiveClassifier = 'sources'
26+
from sourceSets.main.allSource
27+
}
28+
}
29+
if (!tasks.findByName('javadocJar')) {
30+
tasks.register('javadocJar', Jar) {
31+
archiveClassifier = 'javadoc'
32+
from javadoc.destinationDir
33+
}
34+
}

grails-datastore-gorm-tck/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ dependencies {
5353
}
5454

5555
implementation 'org.grails:grails-core', {
56-
// impl: ValidationException
56+
// impl: Entity, ValidationException
5757
if (excludeUnusedTransDeps) {
5858
// API dependencies in grails-core
5959
exclude group: 'jakarta.annotation', module: 'jakarta.annotation-api'

grails-datastore-gorm-test/build.gradle

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,11 @@ dependencies {
6262
// api: SelectClasses, Suite
6363
}
6464
testImplementation project(':grails-datastore-gorm-tck')
65-
/*
66-
testCompileOnly 'org.grails:grails-core', {
67-
// api: Entity
68-
// impl: ValidationException
65+
testImplementation 'org.grails:grails-core', {
66+
// impl: Entity. ValidationException
6967
if (excludeUnusedTransDeps) {
7068
// API dependencies in grails-core
71-
//exclude group: 'jakarta.annotation', module: 'jakarta.annotation-api' // PostConstruct
69+
exclude group: 'jakarta.annotation', module: 'jakarta.annotation-api'
7270
exclude group: 'jakarta.inject', module: 'jakarta.inject-api'
7371
exclude group: 'jakarta.persistence', module: 'jakarta.persistence-api'
7472
//exclude group: 'org.grails', module: 'grails-bootstrap' // Resource
@@ -82,7 +80,6 @@ dependencies {
8280
exclude group: 'org.springframework.boot', module: 'spring-boot-autoconfigure'
8381
}
8482
}
85-
*/
8683
testImplementation 'org.spockframework:spock-core'
8784

8885
// Commented out since we aren't building / publishing

grails-datastore-gorm/build.gradle

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -40,24 +40,6 @@ dependencies {
4040
api 'jakarta.persistence:jakarta.persistence-api', {
4141
// api: FetchType, JoinType
4242
}
43-
api 'org.grails:grails-core', {
44-
// ast: grails.persistence.Entity
45-
if (excludeUnusedTransDeps) {
46-
// API dependencies in grails-core
47-
exclude group: 'jakarta.annotation', module: 'jakarta.annotation-api'
48-
exclude group: 'jakarta.inject', module: 'jakarta.inject-api'
49-
exclude group: 'jakarta.persistence', module: 'jakarta.persistence-api'
50-
//exclude group: 'org.grails', module: 'grails-bootstrap' // Resource
51-
exclude group: 'org.grails', module: 'grails-datastore-core'
52-
exclude group: 'org.grails', module: 'grails-spring'
53-
exclude group: 'org.springframework', module: 'spring-beans'
54-
exclude group: 'org.springframework', module: 'spring-context'
55-
exclude group: 'org.springframework', module: 'spring-core'
56-
exclude group: 'org.springframework', module: 'spring-tx'
57-
exclude group: 'org.springframework.boot', module: 'spring-boot'
58-
exclude group: 'org.springframework.boot', module: 'spring-boot-autoconfigure'
59-
}
60-
}
6143
api 'org.springframework:spring-context', {
6244
// api: Validator
6345
}

0 commit comments

Comments
 (0)