test: add more waitFor

Author: matrei

.github/workflows/gradle.yml

@@ -47,10 +47,9 @@ jobs:
         run: >
           ./gradlew
           check
-          --max-workers=1
+          --max-workers=2
           --refresh-dependencies
           --continue
-          --no-parallel
           -PgebAtCheckWaiting
   functionalTests:
     if: ${{ !contains(github.event.head_commit.message, '[skip tests]') }}

plugin-acl/examples/functional-test-app/src/integration-test/groovy/test/AdminFunctionalSpec.groovy

@@ -69,12 +69,9 @@ class AdminFunctionalSpec extends AbstractSecuritySpec {
 	void 'view all'() {
 		when:
 		go("report/show?number=$i")
-		waitFor(10, 1) { // 10 seconds, as has shown timeouts in CI
-			title == 'Show Report'
-		}
 
 		then:
-		pageSource.contains("report$i")
+		waitFor { pageSource.contains("report$i") }
 
 		where:
 		i << (1..100)

plugin-acl/examples/functional-test-app/src/integration-test/groovy/test/User1FunctionalSpec.groovy

@@ -70,7 +70,7 @@ class User1FunctionalSpec extends AbstractSecuritySpec {
 		go("report/show?number=$i")
 
 		then:
-		pageSource.contains("report$i")
+		waitFor { pageSource.contains("report$i") }
 
 		where:
 		i << (1..67)
@@ -81,7 +81,7 @@ class User1FunctionalSpec extends AbstractSecuritySpec {
 		go("report/show?number=$i")
 
 		then:
-		pageSource.contains('Access Denied')
+		waitFor { pageSource.contains('Access Denied') }
 
 		where:
 		i << (68..100)
@@ -162,7 +162,7 @@ class User1FunctionalSpec extends AbstractSecuritySpec {
 		grantPage.grantButton.click()
 
 		then:
-		pageSource.contains('Access Denied')
+		waitFor { pageSource.contains('Access Denied') }
 	}
 
 	void 'edit report 20'() {
@@ -178,6 +178,6 @@ class User1FunctionalSpec extends AbstractSecuritySpec {
 		editPage.updateButton.click()
 
 		then:
-		pageSource.contains('Access Denied')
+		waitFor { pageSource.contains('Access Denied') }
 	}
 }