Skip to content

Commit a97e1da

Browse files
committed
refactor setup
1 parent 2090d3c commit a97e1da

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

subprojects/groovy-jmx/src/test/groovy/groovy/jmx/builder/JmxBeanFactoryTest.groovy

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,27 @@
1818
*/
1919
package groovy.jmx.builder
2020

21+
import org.junit.jupiter.api.Assumptions
2122
import org.junit.jupiter.api.BeforeEach
2223
import org.junit.jupiter.api.Test
2324

2425
import javax.management.MBeanServerConnection
2526
import javax.management.ObjectName
2627

27-
class JmxBeanFactoryTest {
28-
def builder
29-
MBeanServerConnection server
28+
final class JmxBeanFactoryTest {
29+
30+
private JmxBuilder builder
31+
private MBeanServerConnection server
3032

3133
@BeforeEach
3234
void setUp() {
3335
builder = new JmxBuilder()
34-
server = builder.getMBeanServer()
35-
builder.registerFactory("bean", new JmxBeanFactory())
36+
builder.registerFactory('bean', new JmxBeanFactory())
37+
try {
38+
server = builder.getMBeanServer()
39+
} catch (e) {
40+
Assumptions.abort(e.getMessage())
41+
}
3642
}
3743

3844
@Test
@@ -66,19 +72,19 @@ class JmxBeanFactoryTest {
6672
assert map.target == object
6773
assert map.name == object.class.canonicalName
6874

69-
assert map.jmxName == new ObjectName("jmx.builder:type=EmbeddedObject")
75+
assert map.jmxName == new ObjectName('jmx.builder:type=EmbeddedObject')
7076
assert map.attributes.Id
71-
assert map.attributes.Id.type == "int"
77+
assert map.attributes.Id.type == 'int'
7278

7379
assert map.attributes.Location
74-
assert map.attributes.Location.type == "java.lang.Object"
80+
assert map.attributes.Location.type == 'java.lang.Object'
7581
}
7682

7783
@Test
7884
void testAttributeMethodListeners() {
7985
def object = new MockManagedGroovyObject()
80-
def map = builder.bean(target: object, name: "jmx.builder:type=ExplicitObject",
81-
attributes: ["Id": [onChange: {-> Hello}]]
86+
def map = builder.bean(target: object, name: 'jmx.builder:type=ExplicitObject',
87+
attributes: ['Id': [onChange: {-> Hello}]]
8288
)
8389

8490
assert map

0 commit comments

Comments
 (0)