YARN-11864. [JDK17] Remove Usage of org.hamcrest in Unit Tests. (#7987)

Author: slfan1989

hadoop-project/pom.xml

@@ -2002,11 +2002,6 @@
           <artifactId>snakeyaml</artifactId>
           <version>${snakeyaml.version}</version>
         </dependency>
-        <dependency>
-          <groupId>org.hamcrest</groupId>
-          <artifactId>hamcrest-library</artifactId>
-          <version>1.3</version>
-        </dependency>
         <dependency>
           <groupId>org.assertj</groupId>
           <artifactId>assertj-core</artifactId>

hadoop-tools/hadoop-aws/pom.xml

@@ -573,11 +573,6 @@
       <artifactId>hadoop-minikdc</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.hamcrest</groupId>
-      <artifactId>hamcrest-library</artifactId>
-      <scope>test</scope>
-    </dependency>
     <!-- Used to create SSL certs for a secure Keystore -->
     <dependency>
       <groupId>org.bouncycastle</groupId>

hadoop-tools/hadoop-azure/pom.xml

@@ -339,11 +339,6 @@
       <artifactId>assertj-core</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.hamcrest</groupId>
-      <artifactId>hamcrest-library</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter-api</artifactId>

hadoop-tools/hadoop-distcp/pom.xml

@@ -109,12 +109,6 @@
       <artifactId>assertj-core</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.hamcrest</groupId>
-      <artifactId>hamcrest-library</artifactId>
-      <version>1.3</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter-api</artifactId>

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/pom.xml

@@ -81,6 +81,11 @@
           <artifactId>junit-platform-launcher</artifactId>
           <scope>test</scope>
       </dependency>
+      <dependency>
+          <groupId>org.assertj</groupId>
+          <artifactId>assertj-core</artifactId>
+          <scope>test</scope>
+      </dependency>
 
       <dependency>
             <groupId>org.apache.solr</groupId>

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppDetailsControllerTest.java

@@ -22,15 +22,15 @@
 import org.apache.hadoop.yarn.appcatalog.model.AppEntry;
 import org.apache.hadoop.yarn.service.api.records.Component;
 import org.apache.hadoop.yarn.service.api.records.Container;
+
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mockito;
 
 import javax.ws.rs.Path;
 import javax.ws.rs.core.Response;
 
-import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.core.Is.is;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.mockito.Mockito.when;
@@ -126,14 +126,15 @@ void testRestartApp() throws Exception {
   void testPathAnnotation() throws Exception {
     assertNotNull(this.controller.getClass()
         .getAnnotations());
-    assertThat("The controller has the annotation Path",
-        this.controller.getClass()
-            .isAnnotationPresent(Path.class));
-
-    final Path path = this.controller.getClass()
-        .getAnnotation(Path.class);
-    assertThat("The path is /app_details", path.value(),
-        is("/app_details"));
+
+    assertThat(this.controller.getClass().isAnnotationPresent(Path.class))
+        .as("The controller has the annotation Path")
+        .isTrue();
+
+    final Path path = this.controller.getClass().getAnnotation(Path.class);
+    assertThat(path.value())
+        .as("The path is /app_details")
+        .isEqualTo("/app_details");
   }
 
   @Test

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppListControllerTest.java

@@ -27,8 +27,7 @@
 import javax.ws.rs.Path;
 import javax.ws.rs.core.Response;
 
-import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.core.Is.is;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.mockito.Mockito.when;
@@ -85,12 +84,15 @@ void testDeploy() throws Exception {
   void testPathAnnotation() throws Exception {
     assertNotNull(this.controller.getClass()
         .getAnnotations());
-    assertThat("The controller has the annotation Path",
-        this.controller.getClass().isAnnotationPresent(Path.class));
 
-    final Path path = this.controller.getClass()
-        .getAnnotation(Path.class);
-    assertThat("The path is /app_list", path.value(), is("/app_list"));
+    assertThat(this.controller.getClass().isAnnotationPresent(Path.class))
+        .as("The controller has the annotation Path")
+            .isTrue();
+
+    final Path path = this.controller.getClass().getAnnotation(Path.class);
+    assertThat(path.value())
+        .as("The path is /app_list")
+        .isEqualTo("/app_list");
   }
 
 }

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppStoreControllerTest.java

@@ -27,8 +27,7 @@
 import javax.ws.rs.Path;
 import javax.ws.rs.core.Response;
 
-import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.core.Is.is;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.mockito.Mockito.when;
@@ -86,13 +85,14 @@ void testRegister() throws Exception {
   void testPathAnnotation() throws Exception {
     assertNotNull(this.controller.getClass()
         .getAnnotations());
-    assertThat("The controller has the annotation Path",
-        this.controller.getClass()
-            .isAnnotationPresent(Path.class));
 
-    final Path path = this.controller.getClass()
-        .getAnnotation(Path.class);
-    assertThat("The path is /app_store", path.value(), is("/app_store"));
-  }
+    assertThat(this.controller.getClass().isAnnotationPresent(Path.class))
+        .as("The controller has the annotation Path")
+        .isTrue();
 
+    final Path path = this.controller.getClass().getAnnotation(Path.class);
+    assertThat(path.value())
+        .as("The path is /app_store")
+        .isEqualTo("/app_store");
+  }
 }

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java

@@ -21,9 +21,7 @@
 
 import org.apache.hadoop.conf.Configuration;
 
-import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.core.IsInstanceOf.instanceOf;
-import static org.hamcrest.core.IsSame.sameInstance;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 /**
@@ -80,7 +78,7 @@ void testCreateInstance() {
     ResourceCalculatorProcessTree tree;
     tree = ResourceCalculatorProcessTree.getResourceCalculatorProcessTree("1", EmptyProcessTree.class, new Configuration());
     assertNotNull(tree);
-    assertThat(tree, instanceOf(EmptyProcessTree.class));
+    assertThat(tree).isInstanceOf(EmptyProcessTree.class);
   }
 
   @Test
@@ -89,6 +87,6 @@ void testCreatedInstanceConfigured() {
     Configuration conf = new Configuration();
     tree = ResourceCalculatorProcessTree.getResourceCalculatorProcessTree("1", EmptyProcessTree.class, conf);
     assertNotNull(tree);
-    assertThat(tree.getConf(), sameInstance(conf));
+    assertThat(tree).isInstanceOf(EmptyProcessTree.class);
   } 
 }