YARN-11838: YARN ConcurrentModificationException When Refreshing Node Attributes (#7828) Contributed by Syed Shameerur Rahman.

* YARN-11838: YARN ConcurrentModificationException When Refreshing Node Attributes.

Signed-off-by: Shilun Fan <[email protected]>

Author: shameersss1

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NodeAttributesManagerImpl.java

@@ -741,7 +741,14 @@ public void refreshNodeAttributesToScheduler(NodeId nodeId) {
     if (host == null || host.attributes == null) {
       return;
     }
-    newNodeToAttributesMap.put(hostName, host.attributes.keySet());
+    // Use read lock and create defensive copy since
+    // other threads might access host.attributes
+    readLock.lock();
+    try {
+      newNodeToAttributesMap.put(hostName, new HashSet<>(host.attributes.keySet()));
+    } finally {
+      readLock.unlock();
+    }
 
     // Notify RM
     if (rmContext != null && rmContext.getDispatcher() != null) {