Skip to content

Commit 949c0d5

Browse files
authored
HDFS-17720.[JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs-rbf Part3. (#7949)
* HDFS-17720.[JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs-rbf Part3. Signed-off-by: Shilun Fan <[email protected]>
1 parent ad12f69 commit 949c0d5

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/rbfbalance/TestRouterDistCpProcedure.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,25 +38,24 @@
3838
import org.apache.hadoop.tools.fedbalance.FedBalanceContext;
3939
import org.apache.hadoop.tools.fedbalance.TestDistCpProcedure;
4040
import org.apache.hadoop.util.Time;
41-
import org.junit.AfterClass;
42-
import org.junit.BeforeClass;
41+
import org.junit.jupiter.api.AfterAll;
42+
import org.junit.jupiter.api.BeforeAll;
4343

4444
import java.net.InetSocketAddress;
4545
import java.net.URI;
4646
import java.util.Collections;
4747

4848
import static org.apache.hadoop.hdfs.server.federation.FederationTestUtils.createNamenodeReport;
4949
import static org.apache.hadoop.test.LambdaTestUtils.intercept;
50-
import static org.junit.Assert.assertTrue;
51-
50+
import static org.junit.jupiter.api.Assertions.assertTrue;
5251

5352
public class TestRouterDistCpProcedure extends TestDistCpProcedure {
5453
private static StateStoreDFSCluster cluster;
5554
private static MiniRouterDFSCluster.RouterContext routerContext;
5655
private static Configuration routerConf;
5756
private static StateStoreService stateStore;
5857

59-
@BeforeClass
58+
@BeforeAll
6059
public static void globalSetUp() throws Exception {
6160
cluster = new StateStoreDFSCluster(false, 1);
6261
// Build and start a router with State Store + admin + RPC
@@ -113,7 +112,7 @@ public void testDisableWrite() throws Exception {
113112
.mkdirs(mount + "/dir", new FsPermission(020), false));
114113
}
115114

116-
@AfterClass
115+
@AfterAll
117116
public static void tearDown() {
118117
cluster.stopRouter(routerContext);
119118
}

hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
import static org.apache.hadoop.security.token.delegation.ZKDelegationTokenSecretManager.ZK_DTSM_TOKEN_WATCHER_ENABLED;
2323
import static org.apache.hadoop.security.token.delegation.web.DelegationTokenManager.REMOVAL_SCAN_INTERVAL;
2424
import static org.apache.hadoop.security.token.delegation.web.DelegationTokenManager.RENEW_INTERVAL;
25-
import static org.junit.Assert.fail;
25+
import static org.junit.jupiter.api.Assertions.assertNotNull;
26+
import static org.junit.jupiter.api.Assertions.fail;
2627

2728
import org.apache.hadoop.conf.Configuration;
2829
import org.apache.hadoop.hdfs.server.federation.router.security.token.ZKDelegationTokenSecretManagerImpl;
@@ -34,8 +35,7 @@
3435
import org.apache.hadoop.security.token.delegation.web.DelegationTokenIdentifier;
3536
import org.apache.hadoop.security.token.delegation.web.DelegationTokenManager;
3637
import org.apache.hadoop.util.Time;
37-
import org.junit.Assert;
38-
import org.junit.Test;
38+
import org.junit.jupiter.api.Test;
3939
import org.slf4j.Logger;
4040
import org.slf4j.LoggerFactory;
4141

@@ -68,7 +68,7 @@ public void testMultiNodeOperationWithoutWatch() throws Exception {
6868
Token<DelegationTokenIdentifier> token =
6969
(Token<DelegationTokenIdentifier>) tm1.createToken(
7070
UserGroupInformation.getCurrentUser(), "foo");
71-
Assert.assertNotNull(token);
71+
assertNotNull(token);
7272
tm2.verifyToken(token);
7373
tm2.renewToken(token, "foo");
7474
tm1.verifyToken(token);
@@ -82,7 +82,7 @@ public void testMultiNodeOperationWithoutWatch() throws Exception {
8282

8383
token = (Token<DelegationTokenIdentifier>) tm2.createToken(
8484
UserGroupInformation.getCurrentUser(), "bar");
85-
Assert.assertNotNull(token);
85+
assertNotNull(token);
8686
tm1.verifyToken(token);
8787
tm1.renewToken(token, "bar");
8888
tm2.verifyToken(token);
@@ -133,7 +133,7 @@ public void testMultiNodeTokenRemovalShortSyncWithoutWatch()
133133
Token<DelegationTokenIdentifier> token =
134134
(Token<DelegationTokenIdentifier>) tm1.createToken(
135135
UserGroupInformation.getCurrentUser(), "foo");
136-
Assert.assertNotNull(token);
136+
assertNotNull(token);
137137
tm2.verifyToken(token);
138138

139139
// time: X + 9
@@ -198,7 +198,7 @@ public void testMultiNodeTokenRemovalLongSyncWithoutWatch()
198198
Token<DelegationTokenIdentifier> token =
199199
(Token<DelegationTokenIdentifier>) tm1.createToken(
200200
UserGroupInformation.getCurrentUser(), "foo");
201-
Assert.assertNotNull(token);
201+
assertNotNull(token);
202202
tm2.verifyToken(token);
203203

204204
// time: X + 9

0 commit comments

Comments
 (0)