Skip to content

Commit a1d2cf4

Browse files
authored
HADOOP-19692. Exclude junit 4 transitive dependency. (#7978)
1 parent 0f18821 commit a1d2cf4

File tree

4 files changed

+15
-13
lines changed

4 files changed

+15
-13
lines changed

hadoop-common-project/hadoop-common/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@
337337
</dependency>
338338
<dependency>
339339
<groupId>com.squareup.okhttp3</groupId>
340-
<artifactId>mockwebserver</artifactId>
340+
<artifactId>mockwebserver3-junit5</artifactId>
341341
<scope>test</scope>
342342
</dependency>
343343
<dependency>

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/http/TestHttpFileSystem.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818

1919
package org.apache.hadoop.fs.http;
2020

21-
import okhttp3.mockwebserver.MockResponse;
22-
import okhttp3.mockwebserver.MockWebServer;
23-
import okhttp3.mockwebserver.RecordedRequest;
21+
import mockwebserver3.MockResponse;
22+
import mockwebserver3.MockWebServer;
23+
import mockwebserver3.RecordedRequest;
2424
import org.apache.hadoop.conf.Configuration;
2525
import org.apache.hadoop.fs.FileSystem;
2626
import org.apache.hadoop.fs.Path;
@@ -55,7 +55,8 @@ public void testHttpFileSystem() throws IOException, URISyntaxException,
5555
InterruptedException {
5656
final String data = "foo";
5757
try (MockWebServer server = new MockWebServer()) {
58-
IntStream.rangeClosed(1, 3).forEach(i -> server.enqueue(new MockResponse().setBody(data)));
58+
final MockResponse response = new MockResponse.Builder().body(data).build();
59+
IntStream.rangeClosed(1, 3).forEach(i -> server.enqueue(response));
5960
server.start();
6061
URI uri = URI.create(String.format("http://%s:%d", server.getHostName(),
6162
server.getPort()));
@@ -64,7 +65,7 @@ public void testHttpFileSystem() throws IOException, URISyntaxException,
6465
assertSameData(fs, new Path("/foo"), data);
6566
assertSameData(fs, new Path("foo"), data);
6667
RecordedRequest req = server.takeRequest();
67-
assertEquals("/foo", req.getPath());
68+
assertEquals("/foo", req.getUrl().encodedPath());
6869
}
6970
}
7071

hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,6 @@
200200
<artifactId>bcprov-jdk18on</artifactId>
201201
<scope>test</scope>
202202
</dependency>
203-
<dependency>
204-
<groupId>com.squareup.okhttp3</groupId>
205-
<artifactId>mockwebserver</artifactId>
206-
<scope>test</scope>
207-
</dependency>
208203
<dependency>
209204
<groupId>org.jetbrains.kotlin</groupId>
210205
<artifactId>kotlin-stdlib-jdk8</artifactId>

hadoop-project/pom.xml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@
140140
<hikari.version>4.0.3</hikari.version>
141141
<derby.version>10.14.2.0</derby.version>
142142
<mssql.version>6.2.1.jre7</mssql.version>
143-
<okhttp3.version>4.11.0</okhttp3.version>
143+
<okhttp3.version>5.1.0</okhttp3.version>
144144
<kotlin-stdlib.version>1.6.20</kotlin-stdlib.version>
145145
<jdom2.version>2.0.6.1</jdom2.version>
146146
<jna.version>5.2.0</jna.version>
@@ -256,7 +256,7 @@
256256
<dependencies>
257257
<dependency>
258258
<groupId>com.squareup.okhttp3</groupId>
259-
<artifactId>mockwebserver</artifactId>
259+
<artifactId>mockwebserver3-junit5</artifactId>
260260
<version>${okhttp3.version}</version>
261261
<scope>test</scope>
262262
<exclusions>
@@ -1392,6 +1392,12 @@
13921392
<groupId>com.googlecode.json-simple</groupId>
13931393
<artifactId>json-simple</artifactId>
13941394
<version>1.1.1</version>
1395+
<exclusions>
1396+
<exclusion>
1397+
<groupId>junit</groupId>
1398+
<artifactId>junit</artifactId>
1399+
</exclusion>
1400+
</exclusions>
13951401
</dependency>
13961402

13971403
<dependency>

0 commit comments

Comments
 (0)