Skip to content

Commit bed8db8

Browse files
authored
HDFS-17829. TestDFSUtil fails with Java 24 beacause of InetSocketAddress.toString changes (#7958) Contributed by Istvan Toth.
* HDFS-17829. TestDFSUtil fails with Java 24 beacause of InetSocketAddress.toString changes Signed-off-by: Shilun Fan <[email protected]>
1 parent faf9a0c commit bed8db8

File tree

1 file changed

+13
-6
lines changed
  • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs

1 file changed

+13
-6
lines changed

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -555,10 +555,10 @@ public void testHANameNodesWithFederation() throws URISyntaxException {
555555
assertTrue(HAUtil.isHAEnabled(conf, "ns2"));
556556
assertFalse(HAUtil.isHAEnabled(conf, "ns3"));
557557

558-
assertEquals(NS1_NN1_HOST, map.get("ns1").get("ns1-nn1").toString());
559-
assertEquals(NS1_NN2_HOST, map.get("ns1").get("ns1-nn2").toString());
560-
assertEquals(NS2_NN1_HOST, map.get("ns2").get("ns2-nn1").toString());
561-
assertEquals(NS2_NN2_HOST, map.get("ns2").get("ns2-nn2").toString());
558+
assertEquals(resolvedName(NS1_NN1_HOST), map.get("ns1").get("ns1-nn1").toString());
559+
assertEquals(resolvedName(NS1_NN2_HOST), map.get("ns1").get("ns1-nn2").toString());
560+
assertEquals(resolvedName(NS2_NN1_HOST), map.get("ns2").get("ns2-nn1").toString());
561+
assertEquals(resolvedName(NS2_NN2_HOST), map.get("ns2").get("ns2-nn2").toString());
562562

563563
assertEquals(NS1_NN1_HOST,
564564
DFSUtil.getNamenodeServiceAddr(conf, "ns1", "ns1-nn1"));
@@ -634,8 +634,8 @@ public void testGetHaNnHttpAddresses() throws IOException {
634634
Map<String, Map<String, InetSocketAddress>> map =
635635
DFSUtilClient.getHaNnWebHdfsAddresses(conf, "webhdfs");
636636

637-
assertEquals(NS1_NN1_ADDR, map.get("ns1").get("nn1").toString());
638-
assertEquals(NS1_NN2_ADDR, map.get("ns1").get("nn2").toString());
637+
assertEquals(resolvedName(NS1_NN1_ADDR), map.get("ns1").get("nn1").toString());
638+
assertEquals(resolvedName(NS1_NN2_ADDR), map.get("ns1").get("nn2").toString());
639639
}
640640

641641
private static Configuration createWebHDFSHAConfiguration(String logicalHostName, String nnaddr1, String nnaddr2) {
@@ -1212,4 +1212,11 @@ private void testLazyResolved(boolean isLazy) {
12121212
});
12131213
});
12141214
}
1215+
1216+
private String resolvedName(String jdk13) {
1217+
if (Shell.isJavaVersionAtLeast(14)) {
1218+
return jdk13.replaceAll(":", "/<unresolved>:");
1219+
}
1220+
return jdk13;
1221+
}
12151222
}

0 commit comments

Comments
 (0)