Skip to content

HADOOP-19709. [JDK17] Add debian:12 and debian:13 as a build platform with JDK-17 as default #8001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

HADOOP-19709. [JDK17] Add debian:12 and debian:13 as a build platform with JDK-17 as default #8001

wants to merge 1 commit into from
+353 −3

Conversation

vinayakumarb
Copy link
Contributor

This commit introduces support for Debian 12 (Bookworm) and Debian 13 (Trixie) as build platforms, following the approach established for Ubuntu 24.

Key changes include:

  • Creation of Dockerfile_debian_12 and Dockerfile_debian_13 based on Dockerfile_ubuntu_24, with appropriate base images and package resolver arguments.
  • Updates to dev-support/docker/pkg-resolver/packages.json to include package definitions for debian:12 and debian:13.
  • Addition of debian:12 and debian:13 to dev-support/docker/pkg-resolver/platforms.json.
  • Modification of BUILDING.txt to list debian_12 and debian_13 as supported OS platforms.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 23m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 hadolint 0m 0s hadolint was not available.
+0 🆗 shellcheck 0m 0s Shellcheck was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 jsonlint 0m 0s jsonlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 37m 46s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
-1 ❌ blanks 0m 0s /blanks-eol.txt The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 shadedclient 34m 39s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 53s The patch does not generate ASF License warnings.
98m 48s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8001/1/artifact/out/Dockerfile
GITHUB PR #8001
Optional Tests dupname asflicense codespell detsecrets hadolint shellcheck shelldocs jsonlint
uname Linux 01b5b1df2935 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 7ccea84
Max. process+thread count 554 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8001/1/console
versions git=2.43.7 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RUN echo 'APT::Install-Suggests "0";' >>  /etc/apt/apt.conf.d/10disableextras

This is there in only in 12, if possible we should sync it with 13 as well, if relevant. Feel free to commit once you do it

@pan3793
Copy link
Member

pan3793 commented Sep 28, 2025

Previously, there were concerns about having many versions of Linux dist Dockerfiles, how about upgrading Debian 10 to 13 directly?

cnauroth
cnauroth approved these changes Sep 28, 2025
View reviewed changes
Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks @vinayakumarb !

@slfan1989
Copy link
Contributor

Previously, there were concerns about having many versions of Linux dist Dockerfiles, how about upgrading Debian 10 to 13 directly?

@vinayakumarb Thank you very much for your contribution. However, I still have some concerns. Expanding support to many operating systems could be a rather heavy undertaking, since it requires us to pay closer attention to their EOL and version lifecycles. I'm wondering if it might be more sustainable to maintain a smaller subset of supported systems instead. If users have other requirements, they could always try customizing the build themselves.

cc: @pan3793 @ayushtkn @cnauroth

@vinayakumarb
HADOOP-19709. [JDK17] Add debian:12 and debian:13 as a build platform…
92bd747 
… with JDK-17 as default

This commit introduces support for Debian 12 (Bookworm) and Debian 13 (Trixie)
as build platforms, following the approach established for Ubuntu 24.

Key changes include:
- Creation of `Dockerfile_debian_12` and `Dockerfile_debian_13` based on
  `Dockerfile_ubuntu_24`, with appropriate base images and package resolver
  arguments.
- Updates to `dev-support/docker/pkg-resolver/packages.json` to include
  package definitions for `debian:12` and `debian:13`.
- Addition of `debian:12` and `debian:13` to
  `dev-support/docker/pkg-resolver/platforms.json`.
- Modification of `BUILDING.txt` to list `debian_12` and `debian_13` as
  supported OS platforms.
@vinayakumarb vinayakumarb force-pushed the features/HADOOP-19709 branch from 7ccea84 to 92bd747 Compare October 7, 2025 10:45
@vinayakumarb
Copy link
Contributor Author

vinayakumarb commented Oct 7, 2025 •
edited
Loading

Previously, there were concerns about having many versions of Linux dist Dockerfiles, how about upgrading Debian 10 to 13 directly?

@vinayakumarb Thank you very much for your contribution. However, I still have some concerns. Expanding support to many operating systems could be a rather heavy undertaking, since it requires us to pay closer attention to their EOL and version lifecycles. I'm wondering if it might be more sustainable to maintain a smaller subset of supported systems instead. If users have other requirements, they could always try customizing the build themselves.

cc: @pan3793 @ayushtkn @cnauroth

I understand the concern.
Directly upgrading the debian:10 to debian:13 may break existing pipelines.

However, having Dockerfiles for various platforms provides the option for developers to build an environment as per their choice. It does not necessarily mean Hadoop binaries (jars and tar) are compiled in these.

if users are interested in building Hadoop in their own choice of environment, these Dockerfiles will be a good starting point.

@slfan1989
Copy link
Contributor

@vinayakumarb Thank you for the clarification — I agree (+1). However, given the complexity of operating system EOL management, I would carefully evaluate the introduction of Docker support for new systems in the future, considering both maintenance costs and long-term sustainability.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 31m 43s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 hadolint 0m 0s hadolint was not available.
+0 🆗 shellcheck 0m 0s Shellcheck was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 jsonlint 0m 0s jsonlint was not available.
+1 💚 @author 0m 1s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 40m 53s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
-1 ❌ blanks 0m 0s /blanks-eol.txt The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 shadedclient 37m 52s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
113m 29s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8001/2/artifact/out/Dockerfile
GITHUB PR #8001
Optional Tests dupname asflicense codespell detsecrets hadolint shellcheck shelldocs jsonlint
uname Linux 9e7987a7030b 5.15.0-153-generic #163-Ubuntu SMP Thu Aug 7 16:37:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 92bd747
Max. process+thread count 647 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8001/2/console
versions git=2.43.7 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnauroth cnauroth cnauroth approved these changes

@ayushtkn ayushtkn ayushtkn approved these changes

@slfan1989 slfan1989 slfan1989 approved these changes

Assignees
No one assigned
Labels
Infra trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vinayakumarb @hadoop-yetus @pan3793 @slfan1989 @cnauroth @ayushtkn