-
Notifications
You must be signed in to change notification settings - Fork 167
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededpluginRelates to a Hamilton plugin (adapters, materializers, etc.)Relates to a Hamilton plugin (adapters, materializers, etc.)pythonPull requests that update python codePull requests that update python codetriagelabel for issues that need to be triaged.label for issues that need to be triaged.
Description
Current behavior
The mlflow plugin doesn't log the graph outcome, which leads to mlflow UI appearing to report a run was a success.
hamilton/hamilton/plugins/h_mlflow.py
Line 332 in 45feeaf
| mlflow.end_run() |
Stack Traces
(If applicable)
Screenshots
Steps to replicate behavior
- Use hamilton mlflow integration
- Create and run dag with exception
- Observe logged run_id displays as succeeded despite failure
Library & System Information
python3.11
mlflow==3.5.1
sf-hamilton[pandera,tqdm]>=1.88.0
Expected behavior
Mlflow should display the run has failed rather than succeeded.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededpluginRelates to a Hamilton plugin (adapters, materializers, etc.)Relates to a Hamilton plugin (adapters, materializers, etc.)pythonPull requests that update python codePull requests that update python codetriagelabel for issues that need to be triaged.label for issues that need to be triaged.