Fix NoSuchMethodError in Hop Web when changing GUI options#6546
Merged
hansva merged 1 commit intoapache:mainfrom Feb 11, 2026
Merged
Fix NoSuchMethodError in Hop Web when changing GUI options#6546hansva merged 1 commit intoapache:mainfrom
hansva merged 1 commit intoapache:mainfrom
Conversation
Display.isSystemDarkTheme() method is not available in Eclipse RAP (Web environment). Calling this method causes java.lang.NoSuchMethodError exception when users try to change locale or other GUI options in Hop Web. Changes: - Add EnvironmentUtils.getInstance().isWeb() check in ConfigGuiOptionsTab.java - In reloadValues(): use stored dark mode preference in Web environment - In saveValues(): use checkbox selection value in Web environment This fix allows Hop Web users to change locale and GUI settings without errors.
Contributor
|
Thanks @chuheridangwua ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using Hop Web (RAP-based web interface) and changing locale or other GUI options, the application crashes with HTTP 500 error:
java.lang.NoSuchMethodError: 'boolean org.eclipse.swt.widgets.Display.isSystemDarkTheme()'
at org.apache.hop.ui.hopgui.perspective.configuration.tabs.ConfigGuiOptionsTab.saveValues(ConfigGuiOptionsTab.java:945)
Root Cause
Display.isSystemDarkTheme()is a desktop SWT API that is not available in Eclipse RAP (Web environment). TheConfigGuiOptionsTabclass calls this method without checking if running inweb mode.
Solution
Added
EnvironmentUtils.getInstance().isWeb()check before callingDisplay.isSystemDarkTheme():Changes
ui/src/main/java/.../ConfigGuiOptionsTab.javareloadValues()methodsaveValues()methodTesting