Skip to content

#6814 #4743 Task to bump common lang version from 2.x to 3.20.x#6878

Merged
hansva merged 1 commit intoapache:mainfrom
asopapiyush:task/common-lang-bumped-from2.x-3.20.x
Mar 30, 2026
Merged

#6814 #4743 Task to bump common lang version from 2.x to 3.20.x#6878
hansva merged 1 commit intoapache:mainfrom
asopapiyush:task/common-lang-bumped-from2.x-3.20.x

Conversation

@asopapiyush
Copy link
Copy Markdown
Contributor

@asopapiyush asopapiyush commented Mar 26, 2026

Our project currently uses Apache Commons Lang 2.x, which has an active CVE reported against the ClassUtils.getClass() API. This vulnerability exposes the project to potential security risks related to uncontrolled or unsafe class loading. To ensure the security posture of the application, we aim to upgrade to Apache Commons Lang 3.x, where these issues have been addressed.
However, this migration is not straightforward, as Commons Lang 3 introduces major breaking changes, including package restructures (org.apache.commons.lang → org.apache.commons.lang3), method deprecations, behavioral changes, and API incompatibility.
This task involves refactoring the codebase to support Commons Lang 3.x while ensuring functional parity.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@mattcasters
Copy link
Copy Markdown
Contributor

Great work @asopapiyush . I had a look at 507 files and it's mostly changing imports from lang to lang3 and a few maven changes.

@mattcasters
Copy link
Copy Markdown
Contributor

Can you run mvn spotless:apply?

@asopapiyush
Copy link
Copy Markdown
Contributor Author

Can you run mvn spotless:apply?

Yes working on the same, still there are few things I am looking into. Junit improvement and some failure. once done. I will tag you to review and mark the PR ready to review and move it from draft state

@asopapiyush asopapiyush force-pushed the task/common-lang-bumped-from2.x-3.20.x branch 2 times, most recently from 3a4443e to 5955add Compare March 27, 2026 14:54
@asopapiyush asopapiyush marked this pull request as ready for review March 27, 2026 15:25
@asopapiyush
Copy link
Copy Markdown
Contributor Author

image I have Completed the changes and marked the PR ready for review @mattcasters Please help me with the build. I can see the failure in ValueMetadataTest.java but it has cleared properly in local.

@asopapiyush asopapiyush changed the title #6814 Task to bump common lang version from 2.x to 3.20.x #6814 #4743 Task to bump common lang version from 2.x to 3.20.x Mar 27, 2026
@asopapiyush asopapiyush force-pushed the task/common-lang-bumped-from2.x-3.20.x branch from 5955add to c96fd86 Compare March 30, 2026 05:52
@asopapiyush
Copy link
Copy Markdown
Contributor Author

asopapiyush commented Mar 30, 2026

@hansva Can you please approve the workflow and trigger the build once?
I have fixed the failing test cases

@hansva
Copy link
Copy Markdown
Contributor

hansva commented Mar 30, 2026

done, I'm also taking a look at the changes. Thank you for this work @asopapiyush !

@hansva
Copy link
Copy Markdown
Contributor

hansva commented Mar 30, 2026

I think it is some flakyness, runnign the tests locally

@mattcasters
Copy link
Copy Markdown
Contributor

I had it in several cases this past weekend. Running fine locally and still getting a weird error in the PR. Still, it never hurts to double check.

@hansva
Copy link
Copy Markdown
Contributor

hansva commented Mar 30, 2026

It all works locally so I am merging this

@hansva hansva merged commit 8745d6e into apache:main Mar 30, 2026
1 of 2 checks passed
@hansva
Copy link
Copy Markdown
Contributor

hansva commented Mar 30, 2026

ohhhhh, now I see what happened... let me fix that

@asopapiyush
Copy link
Copy Markdown
Contributor Author

@mattcasters @hansva do you want me to pick something else and get it fixed?

@mattcasters
Copy link
Copy Markdown
Contributor

Well, the explorer perspective button keeps focus so keyboard shortcuts no longer work in pipelines and workflows, things like space over a transform or z to open underlying pipeline. Could you have a look and create a ticket? TIA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants