Test classes and methods should have default package visibility

Author: strangelookingnerd

httpcore5-h2/src/test/java/org/apache/hc/core5/http2/config/H2ConfigTest.java

@@ -34,7 +34,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class H2ConfigTest {
+class H2ConfigTest {
 
     @Test
     void builder() {

httpcore5-h2/src/test/java/org/apache/hc/core5/http2/frame/TestDefaultFrameFactory.java

@@ -35,10 +35,10 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-public class TestDefaultFrameFactory {
+class TestDefaultFrameFactory {
 
     @Test
-    public void testDataFrame() throws Exception {
+    void testDataFrame() {
 
         final FrameFactory frameFactory = new DefaultFrameFactory();
 
@@ -51,7 +51,7 @@ public void testDataFrame() throws Exception {
     }
 
     @Test
-    public void testSettingFrame() throws Exception {
+    void testSettingFrame() {
 
         final FrameFactory frameFactory = new DefaultFrameFactory();
         final Frame<ByteBuffer> settingsFrame = frameFactory.createSettings(
@@ -67,7 +67,7 @@ public void testSettingFrame() throws Exception {
     }
 
     @Test
-    public void testResetStreamFrame() throws Exception {
+    void testResetStreamFrame() {
 
         final FrameFactory frameFactory = new DefaultFrameFactory();
         final Frame<ByteBuffer> rstStreamFrame = frameFactory.createResetStream(12, H2Error.INTERNAL_ERROR);
@@ -82,7 +82,7 @@ public void testResetStreamFrame() throws Exception {
     }
 
     @Test
-    public void testGoAwayFrame() throws Exception {
+    void testGoAwayFrame() {
 
         final FrameFactory frameFactory = new DefaultFrameFactory();
         final Frame<ByteBuffer> goAwayFrame = frameFactory.createGoAway(13, H2Error.INTERNAL_ERROR, "Oopsie");

httpcore5-h2/src/test/java/org/apache/hc/core5/http2/frame/TestFrameFlag.java

@@ -29,10 +29,10 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-public class TestFrameFlag {
+class TestFrameFlag {
 
     @Test
-    public void testFrameFlagBasics() throws Exception {
+    void testFrameFlagBasics() {
 
         final int flags = FrameFlag.of(FrameFlag.END_STREAM, FrameFlag.PADDED, FrameFlag.PRIORITY);
         Assertions.assertEquals(0x01 | 0x08 | 0x20, flags);

httpcore5-h2/src/test/java/org/apache/hc/core5/http2/frame/TestH2Settings.java

@@ -31,10 +31,10 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-public class TestH2Settings {
+class TestH2Settings {
 
     @Test
-    public void testH2ParamBasics() throws Exception {
+    void testH2ParamBasics() {
         for (final H2Param param: H2Param.values()) {
             Assertions.assertEquals(param, H2Param.valueOf(param.getCode()));
             Assertions.assertEquals(param.name(), H2Param.toString(param.getCode()));
@@ -46,7 +46,7 @@ public void testH2ParamBasics() throws Exception {
     }
 
     @Test
-    public void testH2SettingBasics() throws Exception {
+    void testH2SettingBasics() {
 
         final H2Setting setting1 = new H2Setting(H2Param.ENABLE_PUSH, 0);
         final H2Setting setting2 = new H2Setting(H2Param.INITIAL_WINDOW_SIZE, 1024);

httpcore5-h2/src/test/java/org/apache/hc/core5/http2/hpack/TestFifoBuffer.java

@@ -30,10 +30,10 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-public class TestFifoBuffer {
+class TestFifoBuffer {
 
     @Test
-    public void testAddRemoveCycle() throws Exception {
+    void testAddRemoveCycle() {
 
         final FifoBuffer fifoBuffer = new FifoBuffer(5);
 
@@ -88,7 +88,7 @@ public void testAddRemoveCycle() throws Exception {
     }
 
     @Test
-    public void testExpand() throws Exception {
+    void testExpand() {
 
         final HPackHeader h1 = new HPackHeader("h", "1");
         final HPackHeader h2 = new HPackHeader("h", "2");

httpcore5-h2/src/test/java/org/apache/hc/core5/http2/hpack/TestFifoLinkedList.java

@@ -30,10 +30,10 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-public class TestFifoLinkedList {
+class TestFifoLinkedList {
 
     @Test
-    public void testAddRemoveCycle() throws Exception {
+    void testAddRemoveCycle() {
 
         final FifoLinkedList fifoLinkedList = new FifoLinkedList();
 
@@ -90,7 +90,7 @@ public void testAddRemoveCycle() throws Exception {
     }
 
     @Test
-    public void testGetIndex() throws Exception {
+    void testGetIndex() {
 
         final FifoLinkedList fifoLinkedList = new FifoLinkedList();